diff options
| author | Sami Shalayel <sami.shalayel@qt.io> | 2025-06-05 09:02:58 +0200 |
|---|---|---|
| committer | Sami Shalayel <sami.shalayel@qt.io> | 2025-06-06 13:04:40 +0200 |
| commit | cb1eaacd1955f3dc991b5a805dc45f0609ccbdec (patch) | |
| tree | 16a0b3c8552b620d40d955a95bd878b0268c3571 /src/qmlworkerscript/qquickworkerscript.cpp | |
| parent | 5068a675c4318466a20a18e1443474c7d2fe7d4b (diff) | |
qmlformat: fix crash on StatementLists
The pointer returned by ensureCommentForNode() is invalidated when the
m_commentedElements map is modified, for example when inserting a new
comment via another ensureCommentForNode().
In the StatementList, we actually don't need to create a comment, we
just need to lookup one comment, so partially revert the apparently
drive-by change from b91ca3e0bc0b7e0b1ec53b41698d2325337dae59.
A separate commit will make ensureCommentForNode() private to avoid
similar crashes in the future.
Fixes: QTBUG-137413
Pick-to: 6.8 6.9 6.10
Change-Id: I6e281cc155e2179a880fa4a876133d90c4afae75
Reviewed-by: Olivier De Cannière <olivier.decanniere@qt.io>
Diffstat (limited to 'src/qmlworkerscript/qquickworkerscript.cpp')
0 files changed, 0 insertions, 0 deletions