aboutsummaryrefslogtreecommitdiffstats
path: root/src/labs/platform
Commit message (Collapse)AuthorAgeFilesLines
* Doc: Fix links to replacement dialogsDavid Boddie2025-10-245-5/+5
| | | | | Change-Id: Ifd85cfa7567aee1e13369b1d16ac0da7bd69a860 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
* Mark security header for the qt labs platformSanthosh Kumar2025-09-1830-0/+30
| | | | | | | | | | No security critical issues identified for the qt labs platform. QUIP: 23 Task-number: QTBUG-136184 Pick-to: 6.10 6.9 6.8 Change-Id: If2d0e6991463ed9994fba8adbc3eef848984ab45 Reviewed-by: MohammadHossein Qanbari <mohammad.qanbari@qt.io>
* Doc: Add textual descriptions for QtLabsPlatform documentation imagesDheerendra Purohit2025-07-118-11/+11
| | | | | | | | | | | Added textual descriptions for all images in the QtLabsPlatform documentation to ensure QDoc generates appropriate alt text. Pick-to: 6.10 6.9 Fixes: QTBUG-136147 Change-Id: Ice484beaa12e2169923a84181257562b720ad61e Reviewed-by: Alexei Cazacov <alexei.cazacov@qt.io> Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
* Qt.labs.platform: Fix revisions for signals in Qt.labs.platformUlf Hermann2025-04-293-4/+4
| | | | | | | | | | | | | There has never been a version 2.1 of Qt.labs.platform. All those signals were added in version 1.1. Amends commit 5246dd2de211ffb81313a5c29ae7894545a28c43. Pick-to: 6.9 6.8 6.5 Task-number: QTBUG-136248 Change-Id: Iee02e95e8b7558d30ab0fe725aa2d80220acfa48 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
* Deprecate the dialogs in Qt.labs.platformOliver Eftevaag2024-12-0511-3/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | With recent improvements made to our dialogs in QtQuick.Dialogs, it would make sense to deprecate our dialogs in labs platform. As I've understood it, this has been the plan all along. Our documentation should also become less confusing as a result. In Qt 6.8, we made all dialogs in QtQuick.Dialogs use top-level popup windows (18c4bf827dabea735435887f84ad1bea4136b1ea), which improves the usability on desktop systems. This was the advantage that the Qt.labs.platform dialogs had over QtQuick.Dialogs, due to the Qt.labs.platform dialogs using our standard dialogs in QtWidgets as fallback, which has always been top-level windows. In Qt 6.9, we're also adding a sidebar to the QtQuick.Dialogs file and font dialogs. [ChangeLog][QtLabsPlatform] FileDialog, FontDialog, FolderDialog, MessageDialog and ColorDialog are now deprecated. Use QtQuick.Dialogs instead. Task-number: QTBUG-130864 Change-Id: I38a5bd66d50a12973607777b4e40f2ae85c98b5d Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* QWidgetPlatform: silence MSVC warning C4065 when build with no widgetsVladimir Belyavsky2024-09-041-5/+7
| | | | | | | | Silence MSVC warning C4065 "switch statement contains 'default' but no 'case' labels" when build with -DFEATURE_widgets=OFF. Change-Id: If22f1d751c650456a00bceaa936ac40199b75331 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
* Remove duplicate exposure of QPlatformDialogHelperMitch Curtis2024-09-041-8/+0
| | | | | | | | | | | | | As found in the 6.8 QML API review: https://codereview.qt-project.org/c/qt/qtdeclarative/+/565442/1/qml-api-review/QtQuick/Templates/plugins.qmltypes#11 Rely on the QML_EXTENDED_NAMESPACE(QPlatformDialogHelper) declaration instead. Pick-to: 6.8 Change-Id: I560bb5583dc8700acdbcb11f8feae07e071641ba Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Doc: Replace \instantiates with \nativetypePaul Wicking2024-08-2013-13/+13
| | | | | | | | | | | Since the implementation of the `\nativetype`-command in QDoc, the `\instantiates`-command is deprecated. Replace the use of the deprecated command in favor of its replacement. Pick-to: 6.8 Task-number: QTBUG-128216 Change-Id: I23d9f66d3f6db2e5f827d7868497a432bb9b0626 Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
* Fix multi-screen menu pop-up locationLu YaNing2024-08-201-1/+1
| | | | | | | | | | | | | | According to f8cf17166c9af147f0b8fea72f5b4a8a6098a5d7 When QT_SCALE_FACTOR is greater than 1, the Popup menu pops up incorrectly on the second screen. Replace the toNativePixels with toNativeLocalPosition. Fixes: QTBUG-127906 Pick-to: 6.5 6.7 6.8 Change-Id: Id320063afccfd3a391426bc6419cbe8855c57b98 Reviewed-by: Inho Lee <inho.lee@qt.io>
* Docs: Organize topics in the qtdeclarative/Qt Labs Platform projectAlexei Cazacov2024-07-251-1/+5
| | | | | | | | | | This commit organizes the articles, so they: - have a reasonable tree structure - can be navigated through the topic tree in the Qt Creator help viewer Task-number: QTBUG-126648 Change-Id: Ie7c7a4a0f804056c0051a25852b7c5e90b6e3526 Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
* QtQuick: Make more logging categories static #2Kaj Grönholm2024-06-251-1/+1
| | | | | | | | | Non-static, non-forward-declared logging categories are deprecated. Task-number: QTBUG-67692 Change-Id: Ie8f09c4a362913cc1609fb062ade89a8b83d63c8 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
* Make more logging categories staticUlf Hermann2024-06-241-1/+1
| | | | | | | Non-static, non-forward-declared logging categories are deprecated. Change-Id: Iaeb0183ef7ca05bbd0f4587166096c29825cc175 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* labs: Straighten out some logging categoriesUlf Hermann2024-06-142-2/+3
| | | | | | | | | | | Either make them static or declare them in a header. We want them to be static wherever possible, in order to reduce the number of visible symbols. If they can't be static, however, they should at least be declared in only one place. Task-number: QTBUG-67692 Change-Id: I72c6ed00ce6e0d81ebb8e0dff93f410bd001342a Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Modernize Qt.labs.platform a bitUlf Hermann2024-04-231-44/+62
| | | | | | | | | | | | | | Separate its plugin from the base library and remove some generated comments. We want to have the base library separate, so that its headers become proper private headers and we can pass --private-headers to qmltyperegistrar. Only with this option it will recognize the QPA headers the module also uses. Also, improve the readability of all the conditions and give it a name that follows Qt's library naming convention. Change-Id: Ieeaa4d69aafe4bb56f198deefbfa7c89e5a1f900 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* QtQml: Add a wrapper builtin for QQmlV4Function*Ulf Hermann2024-04-122-3/+2
| | | | | | | | | This way qmltyperegistrar can recognize it and refrain from warning about it. Task-number: QTBUG-101143 Change-Id: I598140e7e90dbd3e27a78c26eff3d46f0fd3e989 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Correct doc snippet licenseLucie Gérard2024-03-221-1/+1
| | | | | | | | | | | | | | All file under doc/snippet should be license as Documentation snippets and according to QUIP-18 [1] thi is LicenseRef-Qt-Commercial OR BSD-3-Clause [1]: https://contribute.qt-project.org/quips/18 Pick-to: 6.7 6.7.0 Task-number: QTBUG-121787 Change-Id: Iee9bc9b8c2a81695c5825a36768b36db2726bd35 Reviewed-by: Kai Köhne <kai.koehne@qt.io>
* Remove all QML_DECLARE_TYPE from src and toolsUlf Hermann2023-11-1813-30/+0
| | | | | | | | They are generally not useful for anything. Change-Id: I12e959ce9338e6eb7465633496c7921fa09a3fe8 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* QML SystemTrayIcon: Allow resetting tray icon menuVladimir Belyavsky2023-11-131-2/+7
| | | | | | | | | | | | Fix QQuickLabsPlatformSystemTrayIcon::setMenu() logic to allow resetting the tray icon menu. Now we correctly handle `nullptr` menu passed to the function, and update underlying QPlatformSystemTrayIcon instance accordingly. Fixes: QTBUG-119065 Pick-to: 6.6 6.5 Change-Id: Ief6445f4854ff2f59809be315f373e0c1755652b Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
* Labs: code tidies: use the 4-arg connect overloadGiuseppe D'Angelo2023-10-283-5/+5
| | | | | | | | | | The 3-arg connect is error-prone and makes the lifetime of the connection unclear. Change-Id: I35d80ec1faea02e573b8a4d7b6335b45fc96921f Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io> Reviewed-by: Ahmad Samir <a.samirh78@gmail.com> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Doc: Fix undocumented parameters and broken linksTopi Reinio2023-09-151-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * src/qml/jsapi/qjsengine.cpp: (qdoc) warning: Can't link to 'qvariant_cast()' * src/quick/items/qquickrhiitem.cpp: (qdoc) warning: Undocumented parameter 'item' in QQuickRhiItemRenderer::synchronize() (qdoc) warning: Can't link to 'msaaColorBuffer()' (qdoc) warning: Can't link to 'resolveTexture()' * src/quick/scenegraph/util/qsgtextnode.cpp: (qdoc) warning: No such enum item 'Text.NativeRendering' in QSGTextNode::RenderType (qdoc) warning: Undocumented parameter 'color' in QSGTextNode::setColor() (qdoc) warning: Undocumented parameter 'color' in QSGTextNode::setSelectionColor() (qdoc) warning: Undocumented parameter 'viewport' in QSGTextNode::setViewport() * examples/quick/rendercontrol/rendercontrol_rhi/doc/src/ rendercontrol_rhi.qdoc: (qdoc) warning: Can't link to 'QWidget-based' (qdoc) warning: Can't link to 'QAnimationDriver' Mark all documentation modules in qtdeclarative as free of warnings. Change-Id: I97cc059701c351b53cdeeb5fc2feff923c5a76a8 Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Export QQuickPixmapKey and (renamed) QQuickPixmapCache for autotestsShawn Rutledge2023-09-011-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | We need to be able to do a leak check in tst_qquickpixmapcache. So we also need to use the singleton pattern rather than Q_GLOBAL_STATIC. Since it gets more exposed this way, make the badly-encapsulated parts of API available only to friends. It's always been bothersome that various other places in the code are including qquickpixmapcache_p.h to get QQuickPixmap, and qquickpixmapcache_p.h also does not include any class called QQuickPixmapCache as you'd expect; while arguably, QQuickPixmapStore is the cache. Often in comments I've needed to refer to "the code in qquickpixmapcache.cpp" because it's a very private, inbred family of related classes that don't match the header name. So now we split the headers: qquickpixmapcache_p.h is for the cache, which is now called QQuickPixmapCache; and qquickpixmap_p.h is the header most often needed in other places. Most classes in qquickpixmap_p.h are exported, but QQuickPixmapCache itself is not (except for autotests). It cannot be defined in the header that gets included in Particles for example: then it wouldn't link, because the implementation is not (and shouldn't be) exported, and that's not what Particles needs anyway. Task-number: QTBUG-81266 Task-number: QTBUG-114953 Change-Id: Ifd7f253b8bbaa130eb52d5546f342754f99f47bb Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Doc: Remove warninglimit .qdocconf variableTopi Reinio2023-06-271-3/+0
| | | | | | | | | | | | | | | | The most common limit for the maximum number of allowed documentation warnings is zero. As all Qt module docs include() a common configuration from qtbase, it's better to control the base warninglimit from a central location in qtbase/doc/global. This allows for a temporary increase of the limit across all modules as needed - for example, when updating the QDoc binary that the CI provisions to a version that introduces new types of documentation warnings. Task-number: QTBUG-113326 Change-Id: I7e5be717195049a6ce1d0a10ccbb1daeb175d714 Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* QQuickLabsPlatformMenuItem: accept KeySequence in shortcutSami Shalayel2023-06-071-0/+6
| | | | | | | | | | | | | | | | The documentation claims that the shortcut of a menuitem can be bound to a QKeySequence (or at least the qml version of it) but menuitem actually only supports int or strings (that are wrapped into a QVariant). Implement the missing codepath for passing QKeySequence in the QVariant for C++ users, instead of constructing a garbage QKeySequence from the string obtained by QKeySequence::toString(). Fixes: QTBUG-113743 Pick-to: 6.5 6.6 Change-Id: I6f4c659a79a4c23de34be92770815d9e14a6a554 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
* Make properties in the Qt Labs module FINALOliver Eftevaag2023-05-312-4/+4
| | | | | | | | | | | Without setting the FINAL flag, properties can be shadowed by users. This can both cause confusion for non-experienced users, and it causes issues with qmlsc. Task-number: QTBUG-108739 Change-Id: I141953340235040020e7ec64f67019314f0f932b Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Fix build with -no-feature-systemtrayiconTasuku Suzuki2023-02-212-0/+6
| | | | | | Pick-to: 6.5 Change-Id: I04b09223dcc155735fc3893c74cf63594b7fe7f6 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Fix build with -no-feature-menuTasuku Suzuki2023-01-171-0/+4
| | | | | | | | | | | .../qwidgetplatformsystemtrayicon.cpp.o: in function `QWidgetPlatformSystemTrayIcon::createMenu() const': qwidgetplatformsystemtrayicon.cpp:(.text+0xe5): undefined reference to `QWidgetPlatformMenu::QWidgetPlatformMenu(QObject*)' Pick-to: 6.5 Change-Id: I7f953848860b71dcdd2ef18e14e414ca42ecc42b Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
* Adapt to changes in QMessageDialogOptionsTor Arne Vestbø2022-12-151-1/+1
| | | | | | | | | As of qtbase 53b413f1c589d976bbc1eb0ad2cc526633e247db the icon has been renamed. Change-Id: I7e5f55ede5db5e6dea71e2e8163191d6b3a36a23 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* doc: update list of supported native dialogsOliver Eftevaag2022-12-025-3/+8
| | | | | | | | Qt 6.5 introduces a few more native dialogs, speficially the message dialog for macOS and the font dialog and color dialog for iOS. Change-Id: I78bd3df1777b0fad891fd66f442e1075a95a7bd5 Reviewed-by: Doris Verria <doris.verria@qt.io>
* Doc: remove "2" from Qt Quick Controls filesMitch Curtis2022-12-011-1/+1
| | | | | | | | | | | | | Work on this was already started for the documentation in 1abdfe5d5a052f2298b7bf657513dfa7e0c66a56. The CMake target (docs_QuickControls2) probably can't be renamed until we rename the library, which won't happen until Qt 7. Task-number: QTBUG-95413 Change-Id: Ied20805a91286436606577c3de39671a447f27dd Reviewed-by: Paul Wicking <paul.wicking@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
* Fix the popup position of a MenuInho Lee2022-11-101-1/+2
| | | | | | | | | | | QPA code should operate in native coord. Treat QWidgetPlatformMenu::showPopup's input as native coord. Fixes: QTBUG-94619 Fixes: QTBUG-94783 Pick-to: 6.4 Change-Id: Iaa030c96d84e4a588e625fe191e4324f70be961f Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io>
* Doc: unify "Dynamically Generating Menu Items" across modulesMitch Curtis2022-10-213-35/+43
| | | | | | | | | | | | | | Both Qt Quick Controls and Qt Labs Platform can use the exact same snippet for this, so use the same approach in both modules. I would try to reuse the code (and documentation), but I'm not sure if the linking to the types contained within would work, nor if there would be conflicts, so to err on the side of caution, give each module its own copies. Task-number: QTBUG-64554 Change-Id: Id1cac733ad3eda12074234f882eeae289caa438a Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Doc: add Windows to list platforms with native MenuBar supportMitch Curtis2022-10-211-0/+1
| | | | | | | | | 7849aa6e96aa923fca5523afc8cf88edcc0bcf90 added support for native menu bars on Windows. Pick-to: 6.2 6.4 Change-Id: I7fb1384cf171c15063ecc9d80dfd1aa8ea3da7ef Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Port from qAsConst() to std::as_const()Marc Mutz2022-10-073-11/+11
| | | | | | | | | | | | | | We've been requiring C++17 since Qt 6.0, and our qAsConst use finally starts to bother us (QTBUG-99313), so time to port away from it now. Since qAsConst has exactly the same semantics as std::as_const (down to rvalue treatment, constexpr'ness and noexcept'ness), there's really nothing more to it than a global search-and-replace. Task-number: QTBUG-99313 Change-Id: I601bf70f020f511019ed28731ba53b14b765dbf0 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* Port from container::count() and length() to size()Marc Mutz2022-10-076-11/+11
| | | | | | | | | | | | | | | | | | | | This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Change the license of all CMakeLists.txt and *.cmake files to BSDLucie Gérard2022-09-071-1/+1
| | | | | | | Task-number: QTBUG-105718 Change-Id: Id89ed14990804a5024183e75382cc539d4293da1 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* QQuickLabsPlatformFolderDialog: Modify the logic of setting the folderDuan Ting2022-09-071-1/+0
| | | | | | | | | | | | In QQuickPlatformFolderDialog, when triggering acceptance, the folder is set by the value of currentFolder, and the value is set back to currentFolder inside the setFolder function. This action causes currentFolder to be abnormal after the folder is modified. Fixes: QTBUG-104629 Pick-to: 6.2 6.3 6.4 Change-Id: I99978de5bbd019024c499c50f61d6e7b6e7dc140 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
* Deprecate Qt.labs.platform.StandardPathsShawn Rutledge2022-08-293-2/+11
| | | | | | | | | | It's been available in the QtCore module since 6.2. Pick-to: 6.4 Task-number: QTBUG-92806 Change-Id: I4da346823bd29f73c039e13aabd31f2274049974 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Paul Wicking <paul.wicking@qt.io>
* Platform: fix MenuItem being triggered when disabledMitch Curtis2022-08-252-33/+45
| | | | | | | | | | Ensure that we remove shortcuts for a MenuItem when it's disabled, not just when a new shortcut is set. Fixes: QTBUG-89567 Pick-to: 6.2 6.3 6.4 Change-Id: I9c4eeda1a68a23317fe5e7bf517046e4e403c46a Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
* Fix duplicate symbol QPlatformDialogHelperForeignLorn Potter2022-08-221-1/+1
| | | | | | | | | Build failure on static builds Fixes: QTBUG-105601 Pick-to: 6.4 Change-Id: I47261b996bc743836dd950230f5e4d15e170712e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Remove unused .pri files in src/Mitch Curtis2022-07-212-95/+0
| | | | | | Pick-to: 6.2 6.3 6.4 Change-Id: I5babc12a37b878ce693bad136d0e60e937f8e039 Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
* Add license headers to cmake filesLucie Gérard2022-07-081-0/+3
| | | | | | | | | | | | CMakeLists.txt and .cmake files of significant size (more than 2 lines according to our check in tst_license.pl) now have the copyright and license header. Existing copyright statements remain intact Task-number: QTBUG-88621 Change-Id: I72c89a98c42bbc9234d8495e9e503bec81d11037 Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
* Use SPDX license identifiersLucie Gérard2022-06-1150-1864/+100
| | | | | | | | | | | | Replace the current license disclaimer in files by a SPDX-License-Identifier. Files that have to be modified by hand are modified. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
* qquickplatformdialog_p.h: Add missing Q_GADGETUlf Hermann2022-05-181-0/+1
| | | | | | | | | | The QML_* macros only do something if they are picked up by moc. Apparently the "StandardButton" type has silently disappeared in Qt 6.0 and no one has noticed. Pick-to: 6.2 6.3 Change-Id: I3e8bfd083408ca53a283e52dc0038907abb9ebc4 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* Add QtQuick dependency to Qt.labs.platformMarco Bubke2022-05-071-0/+2
| | | | | | | | | QWindow is referenced as parameter type but there is no dependency declared to QtQuick where it is defined. Pick-to: 6.3 6.2 Change-Id: If0118aa7253de8b7c931a12fba78dda574351295 Reviewed-by: Maximilian Goldstein <max.goldstein@qt.io>
* labs.platform: fix displaying of icons in platform MenuVladimir Belyavsky2022-05-021-5/+5
| | | | | | | | | | | | | Looks like it didn't work from the start: platform backend (m_handle) has not yet been created by the time creating a MenuItem component, so m_handle->setIcon() was never called. To make it work and also to make it consistent with syncing of all other properties, let's move m_handle->setIcon() into sync() method. Fixes: QTBUG-103017 Pick-to: 6.2 6.3 Change-Id: Ib457735c840a8621a16ec6363a0c19f0c21fae3b Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Replace uses of deprecated _qs with _s/QStringLiteralSona Kurazyan2022-04-291-1/+3
| | | | | | Task-number: QTBUG-101408 Change-Id: Ic925751b73f52d8fa5add5cacc52d6dd6ea2dc27 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
* Qtqtlabsplatformplugin: includemocsMarc Mutz2022-04-2915-0/+30
| | | | | | | | | | | Including moc files directly into their classes' TU tends to improve codegen and enables extended compiler warnings, e.g. about unused private functions or fields. Pick-to: 6.3 6.2 5.15 Task-number: QTBUG-102948 Change-Id: I57a2897de9178a9facbf3d7a4a9b47be3cfc3ef3 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
* FileDialog: do not add default suffix when content scheme is usedIvan Solovev2022-03-171-1/+6
| | | | | | | | | | | | | | | | | | | On Android when a file is selected using the default file manager, the selected file is reported using the url with "content" scheme. This url does not use file suffixes. Before this patch, if the FileDialog had a defaultSuffix specified, that suffix was added to the returned content url, and as a result the file could not be found. This problem exists FileDialog from both QtQuick.Dialogs and Qt.labs.platforms, so this patch implements the similar fix in both of them. Fixes: QTBUG-94391 Pick-to: 6.3 6.2 Change-Id: Ic6ba95e301857d9b72ee6f5ddb819b9aae9e66e3 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* Make sure all private headers include at least one otherThiago Macieira2022-03-1013-13/+26
| | | | | | | | | | See script in qtbase/util/includeprivate for the rules. Since these files are being touched anyway, I also ran the updatecopyright.pl script too. Change-Id: Ib056b47dde3341ef9a52ffff13ef677e471674b6 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
* qt.labs.platform: Use declarative registrationMaximilian Goldstein2022-01-1720-137/+40
| | | | | | | | Makes qt.labs.platform use declarative registration which also allows the plugin to become optional now. Change-Id: I800b567c52e118485e08cf350509e312c7d01b5f Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
generated by cgit v1.2.3 (git 2.25.1) at 2025-12-02 00:39:27 +0000