aboutsummaryrefslogtreecommitdiffstats
path: root/src/qml/compiler/qv4codegen.cpp
diff options
context:
space:
mode:
authorLars Knoll <lars.knoll@qt.io>2017-06-13 15:04:44 +0200
committerErik Verbruggen <erik.verbruggen@qt.io>2017-06-20 09:24:51 +0000
commit2dda1ae0213c9df917502cdd2077a018a551ccae (patch)
tree43d1fcec4371f0a41720b9bac94eedb7500fa1d8 /src/qml/compiler/qv4codegen.cpp
parent3b3d9a0180a5580f2e86d48f8ef120c5a9e122c8 (diff)
Properly implement Reference::fromMember/fromName
Change-Id: I10374be9cf3e0c245bd71c3b32e9974fcf45c8ba Reviewed-by: Erik Verbruggen <erik.verbruggen@qt.io>
Diffstat (limited to 'src/qml/compiler/qv4codegen.cpp')
-rw-r--r--src/qml/compiler/qv4codegen.cpp5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/qml/compiler/qv4codegen.cpp b/src/qml/compiler/qv4codegen.cpp
index 90cbbf635b..dfa444dde9 100644
--- a/src/qml/compiler/qv4codegen.cpp
+++ b/src/qml/compiler/qv4codegen.cpp
@@ -1689,8 +1689,7 @@ bool Codegen::visit(FieldMemberExpression *ast)
Reference base = expression(ast->base);
if (hasError)
return false;
-// _function->newString(ast->name.toString());
- Reference::fromMember(base, -1); //### TODO
+ Reference::fromMember(base, ast->name.toString());
return false;
}
@@ -1775,7 +1774,7 @@ Codegen::Reference Codegen::referenceForName(const QString &name, bool isLhs)
// global context or with. Lookup by name
loadByName:
- return Reference::fromName(this, -1);
+ return Reference::fromName(this, name);
}
IR::Expr *Codegen::fallbackNameLookup(const QString &name, int line, int col)