diff options
| author | Olivier De Cannière <olivier.decanniere@qt.io> | 2024-10-28 13:50:01 +0100 |
|---|---|---|
| committer | Olivier De Cannière <olivier.decanniere@qt.io> | 2024-11-04 15:21:07 +0100 |
| commit | 09f51978f4ab03f9dcaa36aba4f0c861f59b890c (patch) | |
| tree | ad12513d5120d4e7bfd8edd8498ae50a74e698aa /tools/qmlcachegen/qmlcachegen.cpp | |
| parent | 941b36a98646ae9361e0e72ffebf60bd8cb856d4 (diff) | |
aotstats: Rework cmake deferred calls
The code setting up aotstats is executed when qt_add_qml_module is
called. Within one of these calls we cannot know if more modules will be
added later or whether extra properties will be set on the module
target. We therefore have to defer setting up the dependencies, targets,
and commands until a later point when we have all the necessary
information.
The current implementation has issues. The logic for the project-level
stats which is supposed to collect the module-level stats will in some
cases run before some module-level calls. Those modules would then not
be included in the statistics.
Therefore, defer setting up things until after the CMAKE_BINARY_DIR was
fully evaluated. At that point all the collected module definitions and
target properties can be processed in one go, regardless of their
definition order.
These fixes mean that we can new run all_aotstats on Qt itself and get
proper results!
Fixes: QTBUG-130087
Task-number: QTBUG-124667
Pick-to: 6.8
Change-Id: Ib8ae8b9d7d120fa7ca86a7ad6a14480435564416
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Diffstat (limited to 'tools/qmlcachegen/qmlcachegen.cpp')
0 files changed, 0 insertions, 0 deletions
