libpq: Prevent some overflows of int/size_t
authorJacob Champion <jchampion@postgresql.org>
Mon, 10 Nov 2025 14:02:34 +0000 (06:02 -0800)
committerJacob Champion <jchampion@postgresql.org>
Mon, 10 Nov 2025 14:20:33 +0000 (06:20 -0800)
commit600086f471a3bb57ff4953accf1d3f8d2efe0201
treec164307cfe8e45486fc613d5147ccf73404ce618
parent3e0ae46d907dd5f36342dd288841f4502bd571f6
libpq: Prevent some overflows of int/size_t

Several functions could overflow their size calculations, when presented
with very large inputs from remote and/or untrusted locations, and then
allocate buffers that were too small to hold the intended contents.

Switch from int to size_t where appropriate, and check for overflow
conditions when the inputs could have plausibly originated outside of
the libpq trust boundary. (Overflows from within the trust boundary are
still possible, but these will be fixed separately.) A version of
add_size() is ported from the backend to assist with code that performs
more complicated concatenation.

Reported-by: Aleksey Solovev (Positive Technologies)
Reviewed-by: Noah Misch <noah@leadboat.com>
Reviewed-by: Álvaro Herrera <alvherre@kurilemu.de>
Security: CVE-2025-12818
Backpatch-through: 13
src/interfaces/libpq/fe-connect.c
src/interfaces/libpq/fe-exec.c
src/interfaces/libpq/fe-print.c
src/interfaces/libpq/fe-protocol3.c
src/interfaces/libpq/libpq-int.h