Bump github.com/getlantern/systray from 1.1.0 to 1.2.1 #697
Conversation
|
@dependabot rebase |
08caef4 to
ffc0b02
Compare
ffc0b02 to
137a988
Compare
137a988 to
b5e07d4
Compare
b5e07d4 to
9b85024
Compare
|
Failing, since this needs #720 |
Bumps [github.com/getlantern/systray](https://github.com/getlantern/systray) from 1.1.0 to 1.2.1. - [Release notes](https://github.com/getlantern/systray/releases) - [Changelog](https://github.com/getlantern/systray/blob/master/CHANGELOG.md) - [Commits](getlantern/systray@v1.1.0...v1.2.1) --- updated-dependencies: - dependency-name: github.com/getlantern/systray dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
3b4e41b to
d4bad7d
Compare
per1234
left a comment
There was a problem hiding this comment.
The tester build for this PR fails to start on my Ubuntu 20.04 machine:
./arduino-create-agent: error while loading shared libraries: libayatana-appindicator3.so.1: cannot open shared object file: No such file or directory
(I guess the same as reported at getlantern/systray#191 (comment))
So I think this change will be too problematic for the target user.
|
Thanks a lot for this, Per. I think we can close this one and put all the efforts in #721 then. What do you think? |
|
I'm not knowledgeable enough on the subject to have an opinion other than that we should not expect the target user to install a dependency in order to use the Agent. I did see #721 yesterday while reviewing this and it looks like a very nice diff! |
|
Closing, will be useless after #721 |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps github.com/getlantern/systray from 1.1.0 to 1.2.1.
Changelog
Sourced from github.com/getlantern/systray's changelog.
Commits
a957efeFix +build lines, remove extraneous pkg-config directive59ef333Update CHANGELOG73ea9acSupport libayatana-appindicator on Linux0984344Call out the fact that cgo is required to build229901aCreate menu before calling onReady on Windowse849b2aFix hiding/showing submenus on Windowse2e5b48Fix delFromVisibleItems0831938Update systray_linux.c (#200)2c0986dUpdated changelog for v1.1.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)