Fix checksum doesn't match error
#923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The buffer was not containing the full archive because when red by `extract.Archive(...)` some bytes were skipped because of padding. This was causing the checksum to be different from the expected one
d787bea to
353057e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #923 +/- ##
==========================================
- Coverage 20.94% 20.78% -0.17%
==========================================
Files 43 43
Lines 3161 3200 +39
==========================================
+ Hits 662 665 +3
- Misses 2403 2436 +33
- Partials 96 99 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MatteoPologruto
approved these changes
Mar 18, 2024
alessio-perugini
approved these changes
Mar 18, 2024
Contributor
alessio-perugini
left a comment
There was a problem hiding this comment.
🤯 this will add a bit of overhead memory-wise. If we see some users pointing out memory-related problems it might be this. However, I don't expect this to be a problem as most of the tools are very small in size.
Well done 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
Bug Fix
Close #920
The checksum is properly verified, keeping into account the padding that could be present in the archives
no