Skip to content

Removed unnecessary use of channels #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2024
Merged

Removed unnecessary use of channels #938

merged 1 commit into from
Apr 16, 2024

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Apr 16, 2024

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?
    Refactoring, it should not affect functionality
  • What is the current behavior?
    No changes
  • What is the new behavior?
  • Does this PR introduce a breaking change?
    No
  • Other information:

alessio-perugini
alessio-perugini approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@alessio-perugini alessio-perugini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing on Linux working

  • ✔️ having multiple editors opened
  • ✔️ uploading one sketch

@cmaglie cmaglie self-assigned this Apr 16, 2024
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Apr 16, 2024
@cmaglie cmaglie merged commit 8e28a0c into main Apr 16, 2024
@cmaglie cmaglie deleted the ser_port_hub_refactor branch April 16, 2024 14:47
@cmaglie
Copy link
Member Author

cmaglie commented Apr 16, 2024

Thanks for testing it! 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@umbynos umbynos Awaiting requested review from umbynos

1 more reviewer

@alessio-perugini alessio-perugini alessio-perugini approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cmaglie cmaglie

Labels

topic: code Related to content of the project itself type: enhancement Proposed improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cmaglie @alessio-perugini