From 9e8e59ac5d159cd8fec7f989a633ad8903a1e5c9 Mon Sep 17 00:00:00 2001 From: Denis Yeldandi Date: Tue, 24 Jan 2017 12:44:55 +0300 Subject: [PATCH 1/2] Added error reporting to session code --- php_memcached_session.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/php_memcached_session.c b/php_memcached_session.c index e8f61cf5..21def6de 100644 --- a/php_memcached_session.c +++ b/php_memcached_session.c @@ -442,6 +442,7 @@ PS_READ_FUNC(memcached) *val = ZSTR_EMPTY_ALLOC(); return SUCCESS; } else { + php_error_docref(NULL TSRMLS_CC, E_WARNING, "error getting session from memcached: %s", memcached_last_error_message(memc_sess->memc_sess)); return FAILURE; } } @@ -470,6 +471,8 @@ PS_WRITE_FUNC(memcached) do { if (memcached_set(memc, key->val, key->len, val->val, val->len, expiration, 0) == MEMCACHED_SUCCESS) { return SUCCESS; + } else { + php_error_docref(NULL TSRMLS_CC, E_WARNING, "error saving session to memcached: %s", memcached_last_error_message(memc_sess->memc_sess)); } } while (--retries > 0); From 0f03807ec55b30880ab5dfb9428101ef19153cc9 Mon Sep 17 00:00:00 2001 From: Denis Yeldandi Date: Tue, 24 Jan 2017 13:47:11 +0300 Subject: [PATCH 2/2] memc_sess -> memc typo --- php_memcached_session.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/php_memcached_session.c b/php_memcached_session.c index 21def6de..25ca0ae2 100644 --- a/php_memcached_session.c +++ b/php_memcached_session.c @@ -442,7 +442,7 @@ PS_READ_FUNC(memcached) *val = ZSTR_EMPTY_ALLOC(); return SUCCESS; } else { - php_error_docref(NULL TSRMLS_CC, E_WARNING, "error getting session from memcached: %s", memcached_last_error_message(memc_sess->memc_sess)); + php_error_docref(NULL TSRMLS_CC, E_WARNING, "error getting session from memcached: %s", memcached_last_error_message(memc)); return FAILURE; } } @@ -472,7 +472,7 @@ PS_WRITE_FUNC(memcached) if (memcached_set(memc, key->val, key->len, val->val, val->len, expiration, 0) == MEMCACHED_SUCCESS) { return SUCCESS; } else { - php_error_docref(NULL TSRMLS_CC, E_WARNING, "error saving session to memcached: %s", memcached_last_error_message(memc_sess->memc_sess)); + php_error_docref(NULL TSRMLS_CC, E_WARNING, "error saving session to memcached: %s", memcached_last_error_message(memc)); } } while (--retries > 0);