Skip to content

Set custom webdriver port with ENV var and checking port availability #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Set custom webdriver port with ENV var and checking port availability #1124

wants to merge 3 commits into from

Conversation

@usernameComputer01
Copy link

@usernameComputer01 usernameComputer01 commented Mar 28, 2025 

Chrome: WEBDRIVER_CHROME_CUSTOM_PORT
Firefox: WEBDRIVER_FIREFOX_CUSTOM_PORT

@usernameComputer01
Set custom webdriver port with ENV var
3fc6650 
    Chrome: WEBDRIVER_CHROME_CUSTOM_PORT
    Firefox: WEBDRIVER_FIREFOX_CUSTOM_PORT
@williamdes
Copy link
Collaborator

williamdes commented Mar 28, 2025

Does such env exist in another project ?
could we use more standard ones ?

@usernameComputer01
Copy link
Author

usernameComputer01 commented Mar 28, 2025

Does such env exist in another project ? could we use more standard ones ?

I didn't find any information on the ENV standard for webdriver.

@usernameComputer01 usernameComputer01 force-pushed the main branch 2 times, most recently from b893e92 to 153a1ad Compare March 28, 2025 12:22
@usernameComputer01 usernameComputer01 changed the title Set custom webdriver port with ENV var Set custom webdriver port with ENV var and checking port availability Mar 28, 2025
@usernameComputer01
Copy link
Author

usernameComputer01 commented Mar 28, 2025 •
edited
Loading

Added checking for availability of listening port

williamdes
williamdes reviewed Mar 31, 2025
View reviewed changes
williamdes
williamdes reviewed Mar 31, 2025
View reviewed changes
@usernameComputer01 @williamdes
Update lib/Remote/Service/DriverService.php
ee06ecb 
Co-authored-by: William Desportes <williamdes@wdes.fr>
williamdes
williamdes approved these changes Oct 1, 2025
View reviewed changes
Copy link
Collaborator

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, @OndraM ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@williamdes williamdes williamdes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@usernameComputer01 @williamdes