Remove uses of AssertVariableIsOfType() obsoleted by f2b73c8

anarazel · anarazel · commit 30b789eafed2 · 2023-02-08T21:06:46.000-08:00
Author: Nathan Bossart <nathandbossart@gmail.com> Discussion: https://postgr.es/m/20230208172705.GA451849@nathanxps13
diff --git a/contrib/basic_archive/basic_archive.c b/contrib/basic_archive/basic_archive.c
@@ -81,8 +81,6 @@ _PG_init(void)
 void
 _PG_archive_module_init(ArchiveModuleCallbacks *cb)
 {
-	AssertVariableIsOfType(&_PG_archive_module_init, ArchiveModuleInit);
-
 	cb->check_configured_cb = basic_archive_configured;
 	cb->archive_file_cb = basic_archive_file;
 }
diff --git a/contrib/test_decoding/test_decoding.c b/contrib/test_decoding/test_decoding.c
@@ -127,8 +127,6 @@ _PG_init(void)
 void
 _PG_output_plugin_init(OutputPluginCallbacks *cb)
 {
-	AssertVariableIsOfType(&_PG_output_plugin_init, LogicalOutputPluginInit);
-
 	cb->startup_cb = pg_decode_startup;
 	cb->begin_cb = pg_decode_begin_txn;
 	cb->change_cb = pg_decode_change;
diff --git a/src/backend/postmaster/shell_archive.c b/src/backend/postmaster/shell_archive.c
@@ -29,8 +29,6 @@ static void shell_archive_shutdown(void);
 void
 shell_archive_init(ArchiveModuleCallbacks *cb)
 {
-	AssertVariableIsOfType(&shell_archive_init, ArchiveModuleInit);
-
 	cb->check_configured_cb = shell_archive_configured;
 	cb->archive_file_cb = shell_archive_file;
 	cb->shutdown_cb = shell_archive_shutdown;
diff --git a/src/backend/replication/pgoutput/pgoutput.c b/src/backend/replication/pgoutput/pgoutput.c
@@ -248,8 +248,6 @@ static void pgoutput_column_list_init(PGOutputData *data,
 void
 _PG_output_plugin_init(OutputPluginCallbacks *cb)
 {
-	AssertVariableIsOfType(&_PG_output_plugin_init, LogicalOutputPluginInit);
-
 	cb->startup_cb = pgoutput_startup;
 	cb->begin_cb = pgoutput_begin_txn;
 	cb->change_cb = pgoutput_change;

Original file line number	Diff line number	Diff line change
`@@ -81,8 +81,6 @@ _PG_init(void)`
`81`	`81`	`void`
`82`	`82`	`_PG_archive_module_init(ArchiveModuleCallbacks *cb)`
`83`	`83`	`{`
`84`		`- AssertVariableIsOfType(&_PG_archive_module_init, ArchiveModuleInit);`
`85`		`-`
`86`	`84`	`cb->check_configured_cb = basic_archive_configured;`
`87`	`85`	`cb->archive_file_cb = basic_archive_file;`
`88`	`86`	`}`
Original file line number	Diff line number	Diff line change
`@@ -127,8 +127,6 @@ _PG_init(void)`
`127`	`127`	`void`
`128`	`128`	`_PG_output_plugin_init(OutputPluginCallbacks *cb)`
`129`	`129`	`{`
`130`		`- AssertVariableIsOfType(&_PG_output_plugin_init, LogicalOutputPluginInit);`
`131`		`-`
`132`	`130`	`cb->startup_cb = pg_decode_startup;`
`133`	`131`	`cb->begin_cb = pg_decode_begin_txn;`
`134`	`132`	`cb->change_cb = pg_decode_change;`
Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,6 @@ static void shell_archive_shutdown(void);`
`29`	`29`	`void`
`30`	`30`	`shell_archive_init(ArchiveModuleCallbacks *cb)`
`31`	`31`	`{`
`32`		`- AssertVariableIsOfType(&shell_archive_init, ArchiveModuleInit);`
`33`		`-`
`34`	`32`	`cb->check_configured_cb = shell_archive_configured;`
`35`	`33`	`cb->archive_file_cb = shell_archive_file;`
`36`	`34`	`cb->shutdown_cb = shell_archive_shutdown;`
Original file line number	Diff line number	Diff line change
`@@ -248,8 +248,6 @@ static void pgoutput_column_list_init(PGOutputData *data,`
`248`	`248`	`void`
`249`	`249`	`_PG_output_plugin_init(OutputPluginCallbacks *cb)`
`250`	`250`	`{`
`251`		`- AssertVariableIsOfType(&_PG_output_plugin_init, LogicalOutputPluginInit);`
`252`		`-`
`253`	`251`	`cb->startup_cb = pgoutput_startup;`
`254`	`252`	`cb->begin_cb = pgoutput_begin_txn;`
`255`	`253`	`cb->change_cb = pgoutput_change;`