Remove superfluous memset from pgstat_recv_resetslrucounter

tvondra · tvondra · commit d5d09692ea6b · 2020-05-02T15:30:10.000+02:00
The extra memset meant pg_stat_reset_slru() always reset all the entries even when reset of a single entry was requested, but the timestamp was left uninitialized. Reported-by: Atsushi Torikoshi Discussion: https://postgr.es/m/CACZ0uYFe16pjZxQYaTn53mspyM7dgMPYL3DJLjjPw69GMCC2Ow%40mail.gmail.com
diff --git a/src/backend/postmaster/pgstat.c b/src/backend/postmaster/pgstat.c
@@ -6233,8 +6233,6 @@ pgstat_recv_resetslrucounter(PgStat_MsgResetslrucounter *msg, int len)
 	int			i;
 	TimestampTz	ts = GetCurrentTimestamp();
 
-	memset(&slruStats, 0, sizeof(slruStats));
-
 	for (i = 0; i < SLRU_NUM_ELEMENTS; i++)
 	{
 		/* reset entry with the given index, or all entries (index is -1) */

Original file line number	Diff line number	Diff line change
`@@ -6233,8 +6233,6 @@ pgstat_recv_resetslrucounter(PgStat_MsgResetslrucounter *msg, int len)`
`6233`	`6233`	`int i;`
`6234`	`6234`	`TimestampTz ts = GetCurrentTimestamp();`
`6235`	`6235`
`6236`		`- memset(&slruStats, 0, sizeof(slruStats));`
`6237`		`-`
`6238`	`6236`	`for (i = 0; i < SLRU_NUM_ELEMENTS; i++)`
`6239`	`6237`	`{`
`6240`	`6238`	`/* reset entry with the given index, or all entries (index is -1) */`