Fix potential data corruption during freeze

feodor · feodor · commit 31b8db8e6c1f · 2017-07-06T17:18:55.000+03:00
Fix oversight in 3b97e68 bug fix. Bitwise AND is used instead of OR and it cleans all bits in t_infomask heap tuple field. Backpatch to 9.3
diff --git a/src/backend/access/heap/heapam.c b/src/backend/access/heap/heapam.c
@@ -6627,7 +6627,7 @@ heap_prepare_freeze_tuple(HeapTupleHeader tuple, TransactionId cutoff_xid,
 			frz->t_infomask &= ~HEAP_XMAX_BITS;
 			frz->xmax = newxmax;
 			if (flags & FRM_MARK_COMMITTED)
-				frz->t_infomask &= HEAP_XMAX_COMMITTED;
+				frz->t_infomask |= HEAP_XMAX_COMMITTED;
 			changed = true;
 			totally_frozen = false;
 		}

Original file line number	Diff line number	Diff line change
`@@ -6627,7 +6627,7 @@ heap_prepare_freeze_tuple(HeapTupleHeader tuple, TransactionId cutoff_xid,`
`6627`	`6627`	`frz->t_infomask &= ~HEAP_XMAX_BITS;`
`6628`	`6628`	`frz->xmax = newxmax;`
`6629`	`6629`	`if (flags & FRM_MARK_COMMITTED)`
`6630`		`- frz->t_infomask &= HEAP_XMAX_COMMITTED;`
	`6630`	`+ frz->t_infomask \|= HEAP_XMAX_COMMITTED;`
`6631`	`6631`	`changed = true;`
`6632`	`6632`	`totally_frozen = false;`
`6633`	`6633`	`}`