pg_dump/pg_dumpall: remove unnecessary SQL trailing semicolons

bmomjian · bmomjian · commit 8eb29194fc17 · 2013-07-31T11:37:17.000-04:00
Patch by Ian Lawrence Barwick
diff --git a/src/bin/pg_dump/pg_dump.c b/src/bin/pg_dump/pg_dump.c
@@ -12761,7 +12761,6 @@ createViewAsClause(Archive *fout, TableInfo *tbinfo)
 		appendPQExpBuffer(query, "SELECT definition AS viewdef "
 						  "FROM pg_views WHERE viewname = ");
 		appendStringLiteralAH(query, tbinfo->dobj.name, fout);
-		appendPQExpBuffer(query, ";");
 	}
 
 	res = ExecuteSqlQuery(fout, query->data, PGRES_TUPLES_OK);
diff --git a/src/bin/pg_dump/pg_dumpall.c b/src/bin/pg_dump/pg_dumpall.c
@@ -1428,8 +1428,6 @@ dumpDatabaseConfig(PGconn *conn, const char *dbname)
 		if (server_version >= 90000)
 			appendPQExpBuffer(buf, ")");
 
-		appendPQExpBuffer(buf, ";");
-
 		res = executeQuery(conn, buf->data);
 		if (PQntuples(res) == 1 &&
 			!PQgetisnull(res, 0, 0))

Original file line number	Diff line number	Diff line change
`@@ -12761,7 +12761,6 @@ createViewAsClause(Archive fout, TableInfo tbinfo)`
`12761`	`12761`	`appendPQExpBuffer(query, "SELECT definition AS viewdef "`
`12762`	`12762`	`"FROM pg_views WHERE viewname = ");`
`12763`	`12763`	`appendStringLiteralAH(query, tbinfo->dobj.name, fout);`
`12764`		`- appendPQExpBuffer(query, ";");`
`12765`	`12764`	`}`
`12766`	`12765`
`12767`	`12766`	`res = ExecuteSqlQuery(fout, query->data, PGRES_TUPLES_OK);`