Fix bug slowing down pgbench when -P is used.

anarazel · anarazel · commit c2509944b1a0 · 2015-08-08T01:19:02.000+02:00
A removed check in ba3deee made all threads but the main one busy-loop when -P was used. All threads computed the time to the next time the progress report should be printed, but only the main thread did so and re-scheduled it only for the future. Reported-By: Jesper Pedersen Discussion: 55C4E190.3050104@redhat.com
diff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.c
@@ -3646,7 +3646,7 @@ threadRun(void *arg)
 		}
 
 		/* also wake up to print the next progress report on time */
-		if (progress && min_usec > 0)
+		if (progress && min_usec > 0 && thread->tid == 0)
 		{
 			/* get current time if needed */
 			if (now_usec == 0)

Original file line number	Diff line number	Diff line change
`@@ -3646,7 +3646,7 @@ threadRun(void *arg)`
`3646`	`3646`	`}`
`3647`	`3647`
`3648`	`3648`	`/* also wake up to print the next progress report on time */`
`3649`		`- if (progress && min_usec > 0)`
	`3649`	`+ if (progress && min_usec > 0 && thread->tid == 0)`
`3650`	`3650`	`{`
`3651`	`3651`	`/* get current time if needed */`
`3652`	`3652`	`if (now_usec == 0)`