Fix bug in PostgresNode::query_hash's split() call.

tglsfdc · tglsfdc · commit efdb4f29ba9e · 2017-07-02T17:22:09.000-04:00
By default, Perl's split() function drops trailing empty fields, which is not what we want here. Oversight in commit fb093e4. We'd managed to miss it thus far thanks to the very limited usage of this function. Discussion: https://postgr.es/m/14837.1499029831@sss.pgh.pa.us
diff --git a/src/test/perl/PostgresNode.pm b/src/test/perl/PostgresNode.pm
@@ -1533,7 +1533,7 @@ sub query_hash
 	#
 	my %val;
 	@val{@columns} =
-	  $result ne '' ? split(qr/\|/, $result) : ('',) x scalar(@columns);
+	  $result ne '' ? split(qr/\|/, $result, -1) : ('',) x scalar(@columns);
 	return \%val;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1533,7 +1533,7 @@ sub query_hash`
`1533`	`1533`	`#`
`1534`	`1534`	`my %val;`
`1535`	`1535`	`@val{@columns} =`
`1536`		`- $result ne '' ? split(qr/\\|/, $result) : ('',) x scalar(@columns);`
	`1536`	`+ $result ne '' ? split(qr/\\|/, $result, -1) : ('',) x scalar(@columns);`
`1537`	`1537`	`return \%val;`
`1538`	`1538`	`}`
`1539`	`1539`