Skip to content

Conversation

@jakeboone02
Copy link
Member

Fixes #442.

@netlify
Copy link

netlify bot commented Jan 6, 2023

Deploy Preview for react-querybuilder ready!

Name Link
🔨 Latest commit e321113
🔍 Latest deploy log https://app.netlify.com/sites/react-querybuilder/deploys/63b8a8a0fca93b00085e6d85
😎 Deploy Preview https://deploy-preview-443--react-querybuilder.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 6, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e321113:

Sandbox Source
react-querybuilder-ci Configuration
react-querybuilder-dnd-example Configuration
react-querybuilder-antd-example Configuration
react-querybuilder-bootstrap-example Configuration
react-querybuilder-bulma-example Configuration
react-querybuilder-chakra-example Configuration
react-querybuilder-material-example Configuration

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #443 (e321113) into main (2d06d29) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main      #443      +/-   ##
===========================================
+ Coverage   99.96%   100.00%   +0.03%     
===========================================
  Files         100       101       +1     
  Lines        3116      3132      +16     
  Branches     1494      1510      +16     
===========================================
+ Hits         3115      3132      +17     
+ Misses          1         0       -1     
Impacted Files Coverage Δ
packages/react-querybuilder/src/QueryBuilder.tsx 100.00% <100.00%> (ø)
...s/react-querybuilder/src/internal/regenerateIDs.ts 100.00% <100.00%> (ø)
...ackages/react-querybuilder/src/utils/generateID.ts 100.00% <100.00%> (+6.66%) ⬆️
...es/react-querybuilder/src/utils/generateIDtests.ts 100.00% <100.00%> (ø)
...eact-querybuilder/src/utils/prepareQueryObjects.ts 100.00% <100.00%> (ø)
...ackages/react-querybuilder/src/utils/queryTools.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jakeboone02 jakeboone02 changed the title Remove require('crypto') from generateID Remove require('crypto') from generateID and add idGenerator prop Jan 6, 2023
@jakeboone02 jakeboone02 merged commit 319d898 into main Jan 6, 2023
@jakeboone02 jakeboone02 deleted the remove-require-crypto branch January 6, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using the crypto module causes an error when building via esbuild with target not Node

2 participants