AngularJS Uncaught ReferenceError: controller is not defined from module

Question

I have the following code;

var app =
    angular.
        module("myApp",[]).
        config(function($routeProvider, $locationProvider) {
            $routeProvider.when('/someplace', {
                templateUrl: 'sometemplate.html',
                controller: SomeControl
             });
             // configure html5 to get links working on jsfiddle
             $locationProvider.html5Mode(true);
        });

app.controller('SomeControl', ...);

I get the following error

Uncaught ReferenceError: SomeControl is not defined from myApp

Is the problem just that I can not use app.controller('SomeControl', ...) syntax? when using $routeProvider? is the only working syntax:

function SomeControl(...)

duplicate of: stackoverflow.com/questions/11211999/…

Karen Zilles
– Karen Zilles

2013-07-03 17:53:50 +00:00
Commented Jul 3, 2013 at 17:53 — Karen Zilles
– Karen Zilles, Commented Jul 3, 2013 at 17:53
Thanks @KarlZilles - I searched, but missed that one.

Joshua Wooward
– Joshua Wooward

2013-07-08 16:25:28 +00:00
Commented Jul 8, 2013 at 16:25 — Joshua Wooward
– Joshua Wooward, Commented Jul 8, 2013 at 16:25

Foo L · Accepted Answer · 2013-07-03 17:56:54Z

44

Use quotes:

            controller: 'SomeControl'

answered Jul 3, 2013 at 17:56

Foo L

11.1k8 gold badges43 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Joshua Wooward Over a year ago

DUH, Thanks for finding my small mistake ;)

CampaignWizard · Accepted Answer · 2013-07-03 18:13:38Z

8

Like Foo L said, you need to put quotes around SomeControl. If you don't use quotes, you are referring to the variable SomeControl, which is undefined because you did not use a named function to represent the controller.

When you use the alternative that you mentioned, function SomeControl(...), you define that named function. Otherwise, Angular needs to know that it needs to look up the controller in the myApp module.

Using the app.controller('SomeControl', ...) syntax is better because it does not pollute the global namespace.

answered Jul 3, 2013 at 18:13

CampaignWizard

8488 silver badges11 bronze badges

Comments

grepit · Accepted Answer · 2015-09-03 22:53:44Z

1

The above answers are correct however, this error can also happen :

If the name of the controller in you html or jsp etc page is not matching the actual cotnroller

<div ng-controller="yourControllerName as vm">

Also if the name of the function controller does not match the controller definition then this error can happen too.

angular.module('smart.admin.vip') .controller('yourController', yourController); function yourController($scope, gridSelections, gridCreationService, adminVipService) { var vm = this; activate();

answered Sep 3, 2015 at 22:53

grepit

22.6k6 gold badges109 silver badges82 bronze badges

Collectives™ on Stack Overflow

AngularJS Uncaught ReferenceError: controller is not defined from module

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related