Database Error when insert data with loop

Question

I want to insert data in database with dynamic php variable and when I check the script in database I have only one record :(

$low_0 = 0;
$low_1 = 1;
$low_2 = 2;
$nr = 9;

for ($i = 0; $i < $nr; $i++) {
    $sql = 'INSERT INTO prognoza_curenta (ora, prognoza, min, max, reg_date)
            VALUES (' . "${'low_' . $i}, " . "11," . "22," . "33," . "'$timp')";
    echo "$sql" . "<br>";
}

if (mysqli_query($db, $sql)) {
    echo 'Data send' . "<br>";
} else {
    echo 'Error send.' . mysqli_error($sql) . "<br>";
}

you miss to run mysqli_query inside loop. Also you can concatenate the $sql and only one time. $sql .= 'INSERT....'; — Murad Hasan
– Murad Hasan, Commented May 8, 2016 at 12:53
Start by learning to use prepared statements with bind variables in your SQL queries, ad then you wouldn't need to worry about horribly mangling your strings in this way — Mark Baker
– Mark Baker, Commented May 8, 2016 at 12:53
You are overwriting $sql and only the last loop remains for when you insert it. — Matt
– Matt, Commented May 8, 2016 at 12:53

Matt · Accepted Answer · 2016-05-08 12:56:27Z

1

Change your loop to this:

$sql = 'INSERT INTO prognoza_curenta (ora, prognoza, min, max, reg_date)  VALUES';
for ($i = 0; $i < $nr; $i++) {
    $sql .= ' (' . "${'low_' . $i}, " . "11," . "22," . "33," . "'$timp')";
}

answered May 8, 2016 at 12:56

Matt

1,7573 gold badges13 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Murad Hasan · Accepted Answer · 2016-05-08 14:42:24Z

1

The Solution With prepared Statement:

$stmt = $conn->prepare("INSERT INTO prognoza_curenta (ora, prognoza, min, max, reg_date) VALUES (?, ?, ?, ?, ?)");
$stmt->bind_param("sssss", $ora, $prognoza, $min, $max, $reg_date);

// set parameters and execute
for ($i = 0; $i < $nr; $i++) {
    $ora= ${'low_' . $i};
    $prognoza= "11";
    $min= '22';
    $max = '33';
    $reg_date = $timp;
    $stmt->execute();
}

As Suggested by @MarkBaker, This is procedure of prepare statement. Please let me know.

edited May 8, 2016 at 14:42

answered May 8, 2016 at 13:06

Murad Hasan

9,5932 gold badges23 silver badges43 bronze badges

Collectives™ on Stack Overflow

Database Error when insert data with loop

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related