3

I am trying to create a reddit app (just for practice) for Windows Phone 7 using C# and Json.Net. I am trying to get a hang of converting json to something c# can work with, along with some other things. I can pull in the data I want, but don't know if I am using the correct methods in doing so. Then once I have the json data, I cant convert it to a custom object. Anyways, I'm sure there are tons of things wrong in this code so any help to straighten my heading would be much appreciated.

Here's the code:

   public partial class MainPage : PhoneApplicationPage
    {
        string json = "";
    RootObject topic = new RootObject();
    public MainPage()
    {
        InitializeComponent();
    }
    private void Button_Click(object sender, RoutedEventArgs e)
    {
        textBlock1.Text = "Retrieving...";
        string url = @"http://www.reddit.com/r/all.json";
        HttpWebRequest hWebRequest = (HttpWebRequest)HttpWebRequest.Create(url);
        hWebRequest.Method = "GET";
        hWebRequest.BeginGetResponse(Response_Completed, hWebRequest);
    }
    public void Response_Completed(IAsyncResult result)
    {
        HttpWebRequest request = (HttpWebRequest)result.AsyncState;
        HttpWebResponse response = (HttpWebResponse)request.EndGetResponse(result);
        using (StreamReader streamReader = new StreamReader(response.GetResponseStream()))
        {
            json = streamReader.ReadToEnd();
            topic = JsonConvert.DeserializeObject<RootObject>(json);

        }
        Deployment.Current.Dispatcher.BeginInvoke(() =>
        {
            //textBlock2.Text = topic.data2.title;
            textBlock1.Text = "Done.";
        });

This line tells me that a "new" call is required.

textBlock2.Text = topic.data2.title;

Now this part is giving me the trouble. How do I instantiate data, data2, and child correctly?

     public class MediaEmbed
    {
    }

    public class Data2
    {
        public string domain { get; set; }
        public MediaEmbed media_embed { get; set; }
        public object levenshtein { get; set; }
        public string subreddit { get; set; }
        public string selftext_html { get; set; }
        public string selftext { get; set; }
        public object likes { get; set; }
        public bool saved { get; set; }
        public string id { get; set; }
        public bool clicked { get; set; }
        public string title { get; set; }
        public object media { get; set; }
        public int score { get; set; }
        public bool over_18 { get; set; }
        public bool hidden { get; set; }
        public string thumbnail { get; set; }
        public string subreddit_id { get; set; }
        public string author_flair_css_class { get; set; }
        public int downs { get; set; }
        public bool is_self { get; set; }
        public string permalink { get; set; }
        public string name { get; set; }
        public double created { get; set; }
        public string url { get; set; }
        public string author_flair_text { get; set; }
        public string author { get; set; }
        public double created_utc { get; set; }
        public int num_comments { get; set; }
        public int ups { get; set; }
        //public override string ToString()
        //{
        //    return title;
        //}
    }

    public class Child
    {
        public string kind { get; set; }
        public Data2 data { get; set; }
    }

    public class Data
    {
        public string modhash { get; set; }
        public Child[] children { get; set; }
        public string after { get; set; }
        public object before { get; set; }
    }

    public class RootObject
    {
        public RootObject()
        {
        }
        public string kind { get; set; }
        public Data data = new Data();
        public Data2 data2 = new Data2();
        public Child child = new Child();
    }
}
Improve this question
2
  • Welcome to the site - it is not necessary to add a [solved] tag to the title of your question; marking an answer as accepted is how our site indicates that a question is solved. Commented Dec 18, 2011 at 7:38
  • My apologies, thanks for the info. Commented Dec 18, 2011 at 10:35

1 Answer 1

Reset to default
6

I see a couple of problems with what you have. The first is the structure of the classes you have to deserialize the json data into. Manually writing up classes for this is really tedious and error-prone, and so I generally like to use this site to plug in the json and get out the classes I need and rename as appropriate. I'd then go and find the api docs for the data to fill in any gaps in the classes that the data simply just didn't have.

After that, you only need to deserialize a single instance of the root object class that you now have, rather than a List of them, so something like:

RootObject topics = JsonConvert.DeserializeObject<RootObject>(json);

One other note is that when you're deserializing your data, in your code, you're currently declaring a new local variable called topics which hides your member variable that is also called topics in that particular scope and so if you ever inspect that member variable, you would see that it won't have any data in it. You don't want to be declaring a new variable there, you just want to use the existing member variable, so instead of the previous line, you would just want to do:

topics = JsonConvert.DeserializeObject<RootObject>(json);

Or even this.topics if you want to be really explicit and clear about where that variable is coming from.

Improve this answer
Sign up to request clarification or add additional context in comments.

5 Comments

Thanks for the reply. I have updated my program to abide by what you said and things are better, but I am still having some issues(my own fault). These issues stem from the redditObject class, which I have left called RootObject. When I try to pull a value out of the data2 class, it says I need to create a new instance of that class. However, i'm not exactly sure where to go about doing this. Suggestions? I'll keep at it. Also, I have updated the original post with the new code.
Is there a reason why your RootObject looks the way it does? When I run the json through the converter, I always get: public class RootObject { public string kind { get; set; } public Data data { get; set; } } Then, to get the title of the first item, you would do topic.data.children[0].title
Also, it seems to me like you're not exactly clear on how the structure of the data works. The RootObject contains an instance of a Data class, which in turn contains an array of Children, each of which represents a single topic from all.json. So, you're still receiving a list of topics, as opposed to a single topic, but they're nested within a couple other data structures.
I created the extra methods in the RootClass for reasons unknown to even myself. I have since gone back and recopied the code directly from that sweet json2c# converter. My problem, that is now clear to me, is that I was ignoring the fact that children is an array. I wasn't including the index I wanted to pull data from. Honestly, json and c# is really new to me and I wasn't sure on what the data model would look like and how to work with them together. I'll try this out when I get home. It looks as though all I need is the indexer.
It is working now. I added in the index and all is well. Thanks a lot for your help. By the way, the line to call the title would be topic.data.children[0].data.title;. Just adding that to this post in case anyone is ever looking for the answer.

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.