diff options
| author | Mitch Curtis <mitch.curtis@qt.io> | 2024-07-30 10:39:03 +0800 |
|---|---|---|
| committer | Mitch Curtis <mitch.curtis@qt.io> | 2024-08-09 07:11:39 +0800 |
| commit | 74c019e799fab74b85cd444c1e104638b7dd6c96 (patch) | |
| tree | 84464ce1052ac7db4b6c962e406aa360243bbf4a /src/quicktestutils/quick/visualtestutils.cpp | |
| parent | a0ccf90d7e71fe8515777a143fc9757e48b8a44e (diff) | |
QQuickVisualTestUtils::compareImages: actually check all colors
The function was added in 906d5c5c40183468f9521277c6244a6c46730de6. The
tests there don't only use red, so it looks like this bug has existed
since 2013.
Pick-to: 6.5 6.7 6.8
Change-Id: I4bdf87fe6be0224016baf9a2a80faee6fe61514e
Reviewed-by: JiDe Zhang <zhangjide@uniontech.com>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'src/quicktestutils/quick/visualtestutils.cpp')
| -rw-r--r-- | src/quicktestutils/quick/visualtestutils.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/quicktestutils/quick/visualtestutils.cpp b/src/quicktestutils/quick/visualtestutils.cpp index eb04bf086b..14b5383583 100644 --- a/src/quicktestutils/quick/visualtestutils.cpp +++ b/src/quicktestutils/quick/visualtestutils.cpp @@ -159,8 +159,8 @@ bool QQuickVisualTestUtils::compareImages(const QImage &ia, const QImage &ib, QS // No tolerance for error in the alpha. if ((a & 0xff000000) != (b & 0xff000000) || qAbs(qRed(a) - qRed(b)) > tolerance - || qAbs(qRed(a) - qRed(b)) > tolerance - || qAbs(qRed(a) - qRed(b)) > tolerance) { + || qAbs(qGreen(a) - qGreen(b)) > tolerance + || qAbs(qBlue(a) - qBlue(b)) > tolerance) { QDebug(errorMessage) << "Mismatch at:" << x << y << ':' << Qt::hex << Qt::showbase << a << b; return false; |