1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
|
// Copyright (C) 2016 The Qt Company Ltd.
// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only
#include <private/qqmljsengine_p.h>
#include <private/qqmljsparser_p.h>
#include <private/qqmljslexer_p.h>
#include <private/qqmljsastvisitor_p.h>
#include <private/qqmljsast_p.h>
#include <QtQuickTestUtils/private/qmlutils_p.h>
#include <QtQmlDom/private/qqmldomastdumper_p.h>
#include <qtest.h>
#include <QDir>
#include <QDebug>
#include <QRegularExpression>
#include <cstdlib>
class tst_qqmlparser : public QQmlDataTest
{
Q_OBJECT
public:
tst_qqmlparser();
private slots:
void initTestCase() override;
#if !defined(QTEST_CROSS_COMPILED) // sources not available when cross compiled
void qmlParser_data();
void qmlParser();
#endif
void invalidEscapeSequence();
void stringLiteral();
void codeLocationsWithContinuationStringLiteral();
void codeLocationsWithContinuationStringLiteral_data();
void noSubstitutionTemplateLiteral();
void templateLiteral();
void numericSeparator_data();
void numericSeparator();
void invalidNumericSeparator_data();
void invalidNumericSeparator();
void leadingSemicolonInClass();
void templatedReadonlyProperty();
void qmlImportInJS();
void typeAnnotations_data();
void typeAnnotations();
void disallowedTypeAnnotations_data();
void disallowedTypeAnnotations();
void semicolonPartOfExpressionStatement();
void typeAssertion_data();
void typeAssertion();
void annotations_data();
void annotations();
void invalidImportVersion_data();
void invalidImportVersion();
void propertyDeclarations_data();
void propertyDeclarations();
void propertyDeclarationsAST();
void trailingCommaInUiArray();
private:
// TODO move to some utils?
enum SyntaxKind {
// qml
UiProgram,
UiObjectMember,
// js
JSModule,
JSScript,
JSExpression,
JSStatement,
};
struct ParseResult
{
bool success;
QQmlJS::DiagnosticMessage diagnosticMessage;
const QQmlJS::AST::Node *rootNode = nullptr;
};
inline auto parseAs(SyntaxKind kind, const QString &code) -> ParseResult
{
QQmlJS::Lexer lexer(&m_engine);
QQmlJS::Parser parser(&m_engine);
const bool qmlMode = kind == UiProgram || kind == UiObjectMember;
lexer.setCode(code, 1, qmlMode);
const auto parse = [kind, &parser]() -> bool {
switch (kind) {
case UiProgram:
return parser.parse();
case UiObjectMember:
return parser.parseUiObjectMember();
case JSModule:
return parser.parseModule();
case JSScript:
return parser.parseScript();
case JSExpression:
return parser.parseExpression();
case JSStatement:
return parser.parseStatement();
}
Q_UNREACHABLE_RETURN(false);
};
return { parse(), parser.diagnosticMessage(), parser.rootNode() };
}
private:
QStringList excludedDirs;
// need to make sure that its memory pool stays alive during the test
QQmlJS::Engine m_engine;
QStringList findFiles(const QDir &);
};
namespace check {
using namespace QQmlJS;
class Check: public AST::Visitor
{
QList<AST::Node *> nodeStack;
public:
void operator()(AST::Node *node)
{
AST::Node::accept(node, this);
}
virtual void checkNode(AST::Node *node)
{
if (! nodeStack.isEmpty()) {
AST::Node *parent = nodeStack.last();
const qsizetype parentBegin = parent->firstSourceLocation().begin();
const qsizetype parentEnd = parent->lastSourceLocation().end();
if (node->firstSourceLocation().begin() < parentBegin)
qDebug() << "first source loc failed: node:" << node->kind << "at" << node->firstSourceLocation().startLine << "/" << node->firstSourceLocation().startColumn
<< "parent" << parent->kind << "at" << parent->firstSourceLocation().startLine << "/" << parent->firstSourceLocation().startColumn;
if (node->lastSourceLocation().end() > parentEnd)
qDebug() << "last source loc failed: node:" << node->kind << "at" << node->lastSourceLocation().startLine << "/" << node->lastSourceLocation().startColumn
<< "parent" << parent->kind << "at" << parent->lastSourceLocation().startLine << "/" << parent->lastSourceLocation().startColumn;
QVERIFY(node->firstSourceLocation().begin() >= parentBegin);
QVERIFY(node->lastSourceLocation().end() <= parentEnd);
}
}
bool preVisit(AST::Node *node) override
{
checkNode(node);
nodeStack.append(node);
return true;
}
void postVisit(AST::Node *) override
{
nodeStack.removeLast();
}
void throwRecursionDepthError() final
{
QFAIL("Maximum statement or expression depth exceeded");
}
};
struct TypeAnnotationObserver: public AST::Visitor
{
bool typeAnnotationSeen = false;
void operator()(AST::Node *node)
{
AST::Node::accept(node, this);
}
bool visit(AST::TypeAnnotation *) override
{
typeAnnotationSeen = true;
return true;
}
void throwRecursionDepthError() final
{
QFAIL("Maximum statement or expression depth exceeded");
}
};
struct ExpressionStatementObserver: public AST::Visitor
{
int expressionsSeen = 0;
bool endsWithSemicolon = true;
void operator()(AST::Node *node)
{
AST::Node::accept(node, this);
}
bool visit(AST::ExpressionStatement *statement) override
{
++expressionsSeen;
endsWithSemicolon = endsWithSemicolon
&& (statement->lastSourceLocation().end() == statement->semicolonToken.end());
return true;
}
void throwRecursionDepthError() final
{
QFAIL("Maximum statement or expression depth exceeded");
}
};
class CheckLocations : public Check
{
public:
CheckLocations(const QString &code)
{
m_codeStr = code;
m_code = code.split('\u000A');
}
void checkNode(AST::Node *node) override
{
SourceLocation first = node->firstSourceLocation();
SourceLocation last = node->lastSourceLocation();
int startLine = first.startLine - 1;
int endLine = last.startLine - 1;
QVERIFY(startLine >= 0 && startLine < m_code.size());
QVERIFY(endLine >= 0 && endLine < m_code.size());
const int length = last.offset + last.length - first.offset;
QString expected = m_code.join('\n').mid(first.offset, length);
int startColumn = first.startColumn - 1;
QString found;
while (startLine < endLine) {
found.append(m_code.at(startLine).mid(startColumn)).append('\n');
++startLine;
startColumn = 0;
}
found.append(m_code.at(endLine).mid(startColumn,
last.startColumn + last.length - startColumn - 1));
++startLine;
// handle possible continuation strings correctly
while (found.size() != length && startLine < m_code.size()) {
const QString line = m_code.at(startLine);
found.append('\n');
if (length - found.size() > line.size())
found.append(line);
else
found.append(line.left(length - found.size()));
++startLine;
}
QCOMPARE(expected, found);
SourceLocation combined(first.offset, quint32(last.end() - first.begin()),
first.startLine, first.startColumn);
SourceLocation cStart = combined.startZeroLengthLocation();
SourceLocation cEnd = combined.endZeroLengthLocation(m_codeStr);
QCOMPARE(cStart.begin(), first.begin());
QCOMPARE(cStart.end(), first.begin());
QCOMPARE(cStart.startLine, first.startLine);
QCOMPARE(cStart.startColumn, first.startColumn);
QCOMPARE(cEnd.begin(), last.end());
QCOMPARE(cEnd.end(), last.end());
QCOMPARE(cEnd.startLine, uint(startLine));
int lastNewline = found.lastIndexOf(QLatin1Char('\n'));
if (lastNewline < 0)
lastNewline = -int(combined.startColumn);
QCOMPARE(cEnd.startColumn, found.size() - lastNewline);
}
private:
QString m_codeStr;
QStringList m_code;
};
}
tst_qqmlparser::tst_qqmlparser() : QQmlDataTest(QT_QMLTEST_DATADIR) { }
void tst_qqmlparser::initTestCase()
{
QQmlDataTest::initTestCase();
// Add directories you want excluded here
// These snippets are not expected to run on their own.
excludedDirs << "doc/src/snippets/qml/visualdatamodel_rootindex";
excludedDirs << "doc/src/snippets/qml/qtbinding";
excludedDirs << "doc/src/snippets/qml/imports";
excludedDirs << "doc/src/snippets/qtquick1/visualdatamodel_rootindex";
excludedDirs << "doc/src/snippets/qtquick1/qtbinding";
excludedDirs << "doc/src/snippets/qtquick1/imports";
}
QStringList tst_qqmlparser::findFiles(const QDir &d)
{
for (int ii = 0; ii < excludedDirs.size(); ++ii) {
QString s = excludedDirs.at(ii);
if (d.absolutePath().endsWith(s))
return QStringList();
}
QStringList rv;
const QStringList files = d.entryList(
QStringList() << QLatin1String("*.qml") << QLatin1String("*.js"), QDir::Files);
for (const QString &file : files)
rv << d.absoluteFilePath(file);
const QStringList dirs = d.entryList(QDir::Dirs | QDir::NoDotAndDotDot | QDir::NoSymLinks);
for (const QString &dir : dirs) {
QDir sub = d;
sub.cd(dir);
rv << findFiles(sub);
}
return rv;
}
/*
This test checks all the qml and js files in the QtQml UI source tree
and ensures that the subnode's source locations are inside parent node's source locations
*/
#if !defined(QTEST_CROSS_COMPILED) // sources not available when cross compiled
void tst_qqmlparser::qmlParser_data()
{
QTest::addColumn<QString>("file");
QString examples = QLatin1String(SRCDIR) + "/../../../../examples/";
QString tests = QLatin1String(SRCDIR) + "/../../../../tests/";
QStringList files;
files << findFiles(QDir(examples));
files << findFiles(QDir(tests));
for (const QString &file : std::as_const(files))
QTest::newRow(qPrintable(file)) << file;
}
#endif
#if !defined(QTEST_CROSS_COMPILED) // sources not available when cross compiled
void tst_qqmlparser::qmlParser()
{
QFETCH(QString, file);
using namespace QQmlJS;
QString code;
QFile f(file);
if (f.open(QFile::ReadOnly))
code = QString::fromUtf8(f.readAll());
const bool qmlMode = file.endsWith(QLatin1String(".qml"));
Engine engine;
Lexer lexer(&engine);
lexer.setCode(code, 1, qmlMode);
Parser parser(&engine);
bool ok = qmlMode ? parser.parse() : parser.parseProgram();
if (ok) {
check::Check chk;
chk(parser.rootNode());
}
}
#endif
void tst_qqmlparser::invalidEscapeSequence()
{
using namespace QQmlJS;
Engine engine;
Lexer lexer(&engine);
lexer.setCode(QLatin1String("\"\\"), 1);
Parser parser(&engine);
parser.parse();
}
void tst_qqmlparser::stringLiteral()
{
using namespace QQmlJS;
Engine engine;
Lexer lexer(&engine);
QString code("'hello string'");
lexer.setCode(code , 1);
Parser parser(&engine);
QVERIFY(parser.parseExpression());
AST::ExpressionNode *expression = parser.expression();
QVERIFY(expression);
auto *literal = QQmlJS::AST::cast<QQmlJS::AST::StringLiteral *>(expression);
QVERIFY(literal);
QCOMPARE(literal->value, u"hello string");
QCOMPARE(literal->firstSourceLocation().begin(), 0);
QCOMPARE(literal->lastSourceLocation().end(), quint32(code.size()));
// test for correct handling escape sequences inside strings
QLatin1String leftCode("'hello\\n\\tstring'");
QLatin1String plusCode(" + ");
QLatin1String rightCode("'\\nbye'");
code = leftCode + plusCode + rightCode;
lexer.setCode(code , 1);
QVERIFY(parser.parseExpression());
expression = parser.expression();
QVERIFY(expression);
auto *binaryExpression = QQmlJS::AST::cast<QQmlJS::AST::BinaryExpression *>(expression);
QVERIFY(binaryExpression);
literal = QQmlJS::AST::cast<QQmlJS::AST::StringLiteral *>(binaryExpression->left);
QVERIFY(literal);
QCOMPARE(literal->value, u"hello\n\tstring");
QCOMPARE(literal->firstSourceLocation().begin(), 0);
QCOMPARE(literal->firstSourceLocation().startLine, 1u);
QCOMPARE(literal->lastSourceLocation().end(), quint32(leftCode.size()));
QVERIFY(binaryExpression->right);
literal = QQmlJS::AST::cast<QQmlJS::AST::StringLiteral *>(binaryExpression->right);
QVERIFY(literal);
QCOMPARE(literal->value, u"\nbye");
qsizetype offset = leftCode.size() + plusCode.size();
QCOMPARE(literal->firstSourceLocation().begin(), offset);
QCOMPARE(literal->firstSourceLocation().startLine, 1u);
QCOMPARE(literal->lastSourceLocation().end(), quint32(code.size()));
leftCode = QLatin1String("'\u000Ahello\u000Abye'");
code = leftCode + plusCode + rightCode;
lexer.setCode(code, 1);
QVERIFY(parser.parseExpression());
expression = parser.expression();
QVERIFY(expression);
binaryExpression = QQmlJS::AST::cast<QQmlJS::AST::BinaryExpression *>(expression);
QVERIFY(binaryExpression);
literal = QQmlJS::AST::cast<QQmlJS::AST::StringLiteral *>(binaryExpression->left);
QVERIFY(literal);
QCOMPARE(literal->value, u"\nhello\nbye");
QCOMPARE(literal->firstSourceLocation().begin(), 0);
QCOMPARE(literal->firstSourceLocation().startLine, 1u);
QCOMPARE(literal->lastSourceLocation().end(), leftCode.size());
literal = QQmlJS::AST::cast<QQmlJS::AST::StringLiteral *>(binaryExpression->right);
QVERIFY(literal);
QCOMPARE(literal->value, u"\nbye");
offset = leftCode.size() + plusCode.size();
QCOMPARE(literal->firstSourceLocation().begin(), offset);
QCOMPARE(literal->lastSourceLocation().startLine, 3u);
QCOMPARE(literal->lastSourceLocation().end(), code.size());
}
void tst_qqmlparser::codeLocationsWithContinuationStringLiteral()
{
using namespace QQmlJS;
QFETCH(QString, code);
Engine engine;
Lexer lexer(&engine);
lexer.setCode(code, 1);
Parser parser(&engine);
QVERIFY(parser.parse());
check::CheckLocations chk(code);
chk(parser.rootNode());
}
void tst_qqmlparser::codeLocationsWithContinuationStringLiteral_data()
{
QTest::addColumn<QString>("code");
QString code("A {\u000A"
" property string dummy: \"this\u000A"
" may break lexer\"\u000A"
" B { }\u000A"
"}");
QTest::newRow("withTextBeforeLF") << code;
code = QString("A {\u000A"
" property string dummy: \"\u000A"
" may break lexer\"\u000A"
" B { }\u000A"
"}");
QTest::newRow("withoutTextBeforeLF") << code;
code = QString("A {\u000A"
" property string dummy: \"this\\\u000A"
" may break lexer\"\u000A"
" B { }\u000A"
"}");
QTest::newRow("withTextBeforeEscapedLF") << code;
code = QString("A {\u000A"
" property string dummy: \"th\\\"is\u000A"
" may break lexer\"\u000A"
" B { }\u000A"
"}");
QTest::newRow("withTextBeforeWithEscapeSequence") << code;
code = QString("A {\u000A"
" property string first: \"\u000A"
" first\"\u000A"
" property string dummy: \"th\\\"is\u000A"
" may break lexer\"\u000A"
" B { }\u000A"
"}");
QTest::newRow("withTextBeforeLFwithEscapeSequenceCombined") << code;
// reference data
code = QString("A {\u000A"
" B {\u000A"
" property int dummy: 1\u000A"
" }\u000A"
" C {\u000A"
" D { }\u000A"
" }\u000A"
"}");
QTest::newRow("noStringLiteralAtAll") << code;
}
void tst_qqmlparser::noSubstitutionTemplateLiteral()
{
using namespace QQmlJS;
Engine engine;
Lexer lexer(&engine);
QLatin1String code("`hello template`");
lexer.setCode(code, 1);
Parser parser(&engine);
QVERIFY(parser.parseExpression());
AST::ExpressionNode *expression = parser.expression();
QVERIFY(expression);
auto *literal = QQmlJS::AST::cast<QQmlJS::AST::TemplateLiteral *>(expression);
QVERIFY(literal);
QCOMPARE(literal->value, u"hello template");
QCOMPARE(literal->firstSourceLocation().begin(), 0u);
QCOMPARE(literal->lastSourceLocation().end(), quint32(code.size()));
}
void tst_qqmlparser::templateLiteral()
{
using namespace QQmlJS;
Engine engine;
Lexer lexer(&engine);
QLatin1String code("`one plus one equals ${1+1}!`");
lexer.setCode(code, 1);
Parser parser(&engine);
QVERIFY(parser.parseExpression());
AST::ExpressionNode *expression = parser.expression();
QVERIFY(expression);
auto *templateLiteral = QQmlJS::AST::cast<QQmlJS::AST::TemplateLiteral *>(expression);
QVERIFY(templateLiteral);
QCOMPARE(templateLiteral->firstSourceLocation().begin(), 0);
auto *e = templateLiteral->expression;
QVERIFY(e);
}
void tst_qqmlparser::numericSeparator_data() {
QTest::addColumn<QString>("code");
QTest::addColumn<double>("expected_value");
QTest::newRow("Separator in decimal literal") << "1_000_000_000" << 1000000000.0;
QTest::newRow("Separator in fractional part") << "1000.22_33" << 1000.2233;
QTest::newRow("Separator in exponent part") << "1e1_0_0" << std::pow(10, 100);
QTest::newRow("Separator in positive exponent part") << "1e+1_0_0" << 1e100;
QTest::newRow("Separator in negative exponent part") << "1e-1_0_0" << 1e-100;
QTest::newRow("Separator in binary literal with b prefix") << "0b1010_0001_1000_0101" << static_cast<double>(0b1010000110000101);
QTest::newRow("Separator in binary literal with B prefix") << "0B01_10_01_10" << static_cast<double>(0b01100110);
QTest::newRow("Separator in octal literal with o prefix") << "0o1234_5670" << static_cast<double>(012345670);
QTest::newRow("Separator in octal literal with O prefix") << "0O7777_0000" << static_cast<double>(077770000);
QTest::newRow("Separator in hex literal with x prefix") << "0xA0_B0_C0" << static_cast<double>(0xA0B0C0);
QTest::newRow("Separator in hex literal with X prefix") << "0X1000_AAAA" << static_cast<double>(0x1000AAAA);
}
void tst_qqmlparser::numericSeparator() {
using namespace QQmlJS;
QFETCH(QString, code);
QFETCH(double, expected_value);
QQmlJS::Engine engine;
QQmlJS::Lexer lexer(&engine);
lexer.setCode(code, 1);
QQmlJS::Parser parser(&engine);
QVERIFY(parser.parseExpression());
AST::ExpressionNode *expression = parser.expression();
QVERIFY(expression);
auto *literal = QQmlJS::AST::cast<QQmlJS::AST::NumericLiteral *>(expression);
QVERIFY(literal);
QCOMPARE(literal->value, expected_value);
QCOMPARE(literal->firstSourceLocation().begin(), 0);
QCOMPARE(literal->lastSourceLocation().end(), quint32(code.size()));
}
void tst_qqmlparser::invalidNumericSeparator_data() {
QTest::addColumn<QString>("code");
QTest::addColumn<QString>("error");
QTest::newRow("Trailing numeric separator") << "1_" << "A trailing numeric separator is not allowed in numeric literals";
QTest::newRow("Multiple numeric separators") << "1__2" << "There can be at most one numeric separator between digits";
}
void tst_qqmlparser::invalidNumericSeparator() {
using namespace QQmlJS;
QFETCH(QString, code);
QFETCH(QString, error);
QQmlJS::Engine engine;
QQmlJS::Lexer lexer(&engine);
lexer.setCode(code, 1);
QQmlJS::Parser parser(&engine);
QVERIFY(!parser.parseExpression());
QVERIFY(lexer.errorCode() != Lexer::NoError);
QCOMPARE(lexer.errorMessage(), error);
}
void tst_qqmlparser::leadingSemicolonInClass()
{
QQmlJS::Engine engine;
QQmlJS::Lexer lexer(&engine);
lexer.setCode(QLatin1String("class X{;n(){}}"), 1);
QQmlJS::Parser parser(&engine);
QVERIFY(parser.parseProgram());
}
void tst_qqmlparser::templatedReadonlyProperty()
{
QQmlJS::Engine engine;
QQmlJS::Lexer lexer(&engine);
lexer.setCode(QLatin1String("A { readonly property list<B> listfoo: [ C{} ] }"), 1);
QQmlJS::Parser parser(&engine);
QVERIFY(parser.parse());
}
void tst_qqmlparser::qmlImportInJS()
{
{
QQmlJS::Engine engine;
QQmlJS::Lexer lexer(&engine);
lexer.setCode(QLatin1String(".import Test 1.0 as T"), 0, false);
QQmlJS::Parser parser(&engine);
QVERIFY(parser.parseProgram());
}
{
QQmlJS::Engine engine;
QQmlJS::Lexer lexer(&engine);
lexer.setCode(QLatin1String(".import Test 1 as T"), 0, false);
QQmlJS::Parser parser(&engine);
QVERIFY(parser.parseProgram());
}
{
QQmlJS::Engine engine;
QQmlJS::Lexer lexer(&engine);
lexer.setCode(QLatin1String(".import Test as T"), 0, false);
QQmlJS::Parser parser(&engine);
QVERIFY(parser.parseProgram());
}
}
void tst_qqmlparser::typeAnnotations_data()
{
QTest::addColumn<QString>("file");
QString tests = dataDirectory() + "/typeannotations/";
QStringList files;
files << findFiles(QDir(tests));
for (const QString &file: std::as_const(files))
QTest::newRow(qPrintable(file)) << file;
}
void tst_qqmlparser::typeAnnotations()
{
using namespace QQmlJS;
QFETCH(QString, file);
QString code;
QFile f(file);
if (f.open(QFile::ReadOnly))
code = QString::fromUtf8(f.readAll());
const bool qmlMode = file.endsWith(QLatin1String(".qml"));
Engine engine;
Lexer lexer(&engine);
lexer.setCode(code, 1, qmlMode);
Parser parser(&engine);
bool ok = qmlMode ? parser.parse() : parser.parseProgram();
QVERIFY(ok);
check::TypeAnnotationObserver observer;
observer(parser.rootNode());
QVERIFY(observer.typeAnnotationSeen);
}
void tst_qqmlparser::disallowedTypeAnnotations_data()
{
QTest::addColumn<QString>("file");
QString tests = dataDirectory() + "/disallowedtypeannotations/";
QStringList files;
files << findFiles(QDir(tests));
for (const QString &file: std::as_const(files))
QTest::newRow(qPrintable(file)) << file;
}
void tst_qqmlparser::disallowedTypeAnnotations()
{
using namespace QQmlJS;
QFETCH(QString, file);
QString code;
QFile f(file);
if (f.open(QFile::ReadOnly))
code = QString::fromUtf8(f.readAll());
const bool qmlMode = file.endsWith(QLatin1String(".qml"));
Engine engine;
Lexer lexer(&engine);
lexer.setCode(code, 1, qmlMode);
Parser parser(&engine);
bool ok = qmlMode ? parser.parse() : parser.parseProgram();
QVERIFY(!ok);
QVERIFY2(parser.errorMessage().startsWith("Type annotations are not permitted "), qPrintable(parser.errorMessage()));
}
void tst_qqmlparser::semicolonPartOfExpressionStatement()
{
QQmlJS::Engine engine;
QQmlJS::Lexer lexer(&engine);
lexer.setCode(QLatin1String("A { property int x: 1+1; property int y: 2+2 \n"
"tt: {'a': 5, 'b': 6}; ff: {'c': 'rrr'}}"), 1);
QQmlJS::Parser parser(&engine);
QVERIFY(parser.parse());
check::ExpressionStatementObserver observer;
observer(parser.rootNode());
QCOMPARE(observer.expressionsSeen, 4);
QVERIFY(observer.endsWithSemicolon);
}
void tst_qqmlparser::typeAssertion_data()
{
QTest::addColumn<QString>("expression");
QTest::addRow("as A")
<< QString::fromLatin1("A { onStuff: (b as A).happen() }");
// Rabbits cannot be discerned from types on a syntactical level.
// (rabbits would instead cause an error, as they are lower case)
QTest::addRow("as Rabbit")
<< QString::fromLatin1("A { onStuff: (b as Rabbit).happen() }");
QTest::addRow("as Rabbit paren")
<< QString::fromLatin1("A { onStuff: console.log((12 as Rabbit)); }");
QTest::addRow("as Rabbit noparen")
<< QString::fromLatin1("A { onStuff: console.log(12 as Rabbit); }");
QTest::addRow("property as Rabbit")
<< QString::fromLatin1("A { prop: (12 as Rabbit); }");
QTest::addRow("property noparen as Rabbit")
<< QString::fromLatin1("A { prop: 12 as Rabbit; }");
}
void tst_qqmlparser::typeAssertion()
{
QFETCH(QString, expression);
QQmlJS::Engine engine;
QQmlJS::Lexer lexer(&engine);
lexer.setCode(expression, 1);
QQmlJS::Parser parser(&engine);
QVERIFY(parser.parse());
}
void tst_qqmlparser::annotations_data()
{
QTest::addColumn<QString>("file");
QTest::addColumn<QString>("refFile");
QString tests = dataDirectory() + "/annotations/";
QString compare = dataDirectory() + "/noannotations/";
QStringList files;
files << findFiles(QDir(tests));
QStringList refFiles;
refFiles << findFiles(QDir(compare));
for (const QString &file: std::as_const(files)) {
auto fileNameStart = file.lastIndexOf(QDir::separator());
auto fileName = QStringView(file).mid(fileNameStart, file.size()-fileNameStart);
auto ref=std::find_if(refFiles.constBegin(),refFiles.constEnd(), [fileName](const QString &s){ return s.endsWith(fileName); });
if (ref != refFiles.constEnd())
QTest::newRow(qPrintable(file)) << file << *ref;
else
QTest::newRow(qPrintable(file)) << file << QString();
}
}
void tst_qqmlparser::annotations()
{
using namespace QQmlJS;
QFETCH(QString, file);
QFETCH(QString, refFile);
QString code;
QString refCode;
QFile f(file);
if (f.open(QFile::ReadOnly))
code = QString::fromUtf8(f.readAll());
QFile refF(refFile);
if (!refFile.isEmpty() && refF.open(QFile::ReadOnly))
refCode = QString::fromUtf8(refF.readAll());
const bool qmlMode = true;
Engine engine;
Lexer lexer(&engine);
lexer.setCode(code, 1, qmlMode);
Parser parser(&engine);
QVERIFY(parser.parse());
if (!refCode.isEmpty()) {
Engine engine2;
Lexer lexer2(&engine2);
lexer2.setCode(refCode, 1, qmlMode);
Parser parser2(&engine2);
QVERIFY(parser2.parse());
using namespace QQmlJS::Dom;
QString diff = astNodeDiff(parser.ast(), parser2.rootNode(), 3, AstDumperOption::NoAnnotations | AstDumperOption::NoLocations);
QVERIFY2(diff.isEmpty(), qPrintable(diff));
}
}
void tst_qqmlparser::invalidImportVersion_data()
{
QTest::addColumn<QString>("expression");
const QStringList segments = {
"0", "255", "500", "3030303030303030303030303"
};
for (const QString &major : segments) {
if (major != "0") {
QTest::addRow("%s", qPrintable(major))
<< QString::fromLatin1("import Foo %1").arg(major);
}
for (const QString &minor : segments) {
if (major == "0" && minor == "0")
continue;
QTest::addRow("%s.%s", qPrintable(major), qPrintable(minor))
<< QString::fromLatin1("import Foo %1.%2").arg(major).arg(minor);
}
}
}
void tst_qqmlparser::invalidImportVersion()
{
QFETCH(QString, expression);
QQmlJS::Engine engine;
QQmlJS::Lexer lexer(&engine);
lexer.setCode(expression, 1);
QQmlJS::Parser parser(&engine);
QVERIFY(!parser.parse());
QRegularExpression regexp(
"^Invalid (major )?version. Version numbers must be >= 0 and < 255\\.$");
QVERIFY(regexp.match(parser.errorMessage()).hasMatch());
}
// TODO move somewhere to make more visible? (QTBUG-138020)
namespace Syntax {
using Token = QQmlJSGrammar::VariousConstants;
static constexpr auto spellFor(Token token) -> QLatin1StringView
{
switch (token) {
case Token::T_COLON:
return QLatin1StringView(":");
case Token::T_VAR:
return QLatin1StringView("var");
case Token::T_PROPERTY:
return QLatin1StringView("property");
case Token::T_DEFAULT:
return QLatin1StringView("default");
case Token::T_READONLY:
return QLatin1StringView("readonly");
case Token::T_REQUIRED:
return QLatin1StringView("required");
case Token::T_FINAL:
return QLatin1StringView("final");
case Token::T_VIRTUAL:
return QLatin1StringView("virtual");
case Token::T_OVERRIDE:
return QLatin1StringView("override");
default:
break;
}
Q_UNREACHABLE_RETURN({});
}
using Word = std::variant<Token, QLatin1StringView>;
static inline auto stringView(const Word &word) -> QLatin1StringView
{
return std::holds_alternative<Token>(word) ? spellFor(std::get<Token>(word))
: std::get<QLatin1StringView>(word);
}
using Phrase = QList<Word>;
static inline auto toString(const Phrase &phrase) -> QString
{
QString result;
for (const auto &word : phrase) {
result += stringView(word) + QChar(' ');
}
return result;
}
// comfort
Phrase operator+(const Word &word, const Phrase &phrase)
{
return Phrase{ word } + phrase;
};
Phrase operator+(const Word &word1, const Word &word2)
{
return Phrase{ word1, word2 };
};
} // namespace Syntax
void tst_qqmlparser::propertyDeclarations_data()
{
using namespace Syntax;
QTest::addColumn<QString>("propertyDeclaration");
QTest::addColumn<ParseResult>("expectedParseResult");
const auto addTestRow = [](const Phrase &phrase, const ParseResult &expectedParseResult) {
const QString propertyDeclaration = toString(phrase);
QTest::addRow("%s", qPrintable(propertyDeclaration))
<< propertyDeclaration << expectedParseResult;
};
// can't reuse Parser::compileError unfortunately because it's protected
const auto diagnosticMsg = [](const QString &message,
QtMsgType kind = QtCriticalMsg) -> QQmlJS::DiagnosticMessage {
return QQmlJS::DiagnosticMessage{ message, kind, QQmlJS::SourceLocation() };
};
const auto perfectParseResult = ParseResult{ true, QQmlJS::DiagnosticMessage() };
// For the purposes of this test variables of Phrase type are divirging from camelCase
// this is made for the puposes of them matching closely the end-result test strings,
// e.g. property_var_p -> "property var p"
const Phrase property_var_p = { Token::T_PROPERTY, Token::T_VAR, QLatin1StringView("p") };
const Phrase colon_1 = { Token::T_COLON, QLatin1StringView("1") };
addTestRow(property_var_p, perfectParseResult);
//---------------------------- Default properties ---------------------------------------------
{
const Phrase default_ = { Token::T_DEFAULT };
const Phrase default_property_var_p = default_ + property_var_p;
addTestRow(default_property_var_p, perfectParseResult);
const Phrase default_property_var_p_colon_1 = default_property_var_p + colon_1;
addTestRow(default_property_var_p_colon_1, perfectParseResult);
}
//---------------------------- Readonly properties --------------------------------------------
{
const Phrase readonly = { Token::T_READONLY };
const Phrase readonly_property_var_p = readonly + property_var_p;
addTestRow(
readonly_property_var_p,
ParseResult{ true, diagnosticMsg("Read-only properties require an initializer.") });
const auto readonly_property_var_p_colon_1 = readonly_property_var_p + colon_1;
addTestRow(readonly_property_var_p_colon_1, perfectParseResult);
// TODO cover list properties?
}
//---------------------------- Required properties --------------------------------------------
{
const Phrase required = { Token::T_REQUIRED };
const Phrase required_property_var_p = required + property_var_p;
addTestRow(required_property_var_p, perfectParseResult);
const auto required_property_var_p_colon_1 = required_property_var_p + colon_1;
addTestRow(
required_property_var_p_colon_1,
ParseResult{
true,
diagnosticMsg("Required properties with initializer do not make sense.") });
// TODO cover other rules related to initialization of required properties
}
//---------------------------- Final properties ---------------------------------------------
{
const Phrase final = { Token::T_FINAL };
const Phrase final_property_var_p = final + property_var_p;
addTestRow(final_property_var_p, perfectParseResult);
const Phrase final_property_var_p_colon_1 = final_property_var_p + colon_1;
addTestRow(final_property_var_p_colon_1, perfectParseResult);
}
//---------------------------- Virtual properties ---------------------------------------------
{
const Phrase virtual_property_var_p = Word(Token::T_VIRTUAL) + property_var_p;
addTestRow(virtual_property_var_p, perfectParseResult);
const Phrase virtual_property_var_p_colon_1 = virtual_property_var_p + colon_1;
addTestRow(virtual_property_var_p_colon_1, perfectParseResult);
}
//---------------------------- Override properties ---------------------------------------------
{
const Phrase override_property_var_p = Word(Token::T_OVERRIDE) + property_var_p;
addTestRow(override_property_var_p, perfectParseResult);
const Phrase override_property_var_p_colon_1 = override_property_var_p + colon_1;
addTestRow(override_property_var_p_colon_1, perfectParseResult);
}
//---------------------------- Stacking property attributes -----------------------------------
{
const Phrase final = { Token::T_FINAL };
const Phrase default_ = { Token::T_DEFAULT };
const Phrase readonly = { Token::T_READONLY };
const Phrase required = { Token::T_REQUIRED };
const Phrase virtual_ = { Token::T_VIRTUAL };
const Phrase override_ = { Token::T_OVERRIDE };
// final +
addTestRow(final + default_ + property_var_p, perfectParseResult);
// readonly props require an initializer
addTestRow(final + readonly + property_var_p + colon_1, perfectParseResult);
addTestRow(final + required + property_var_p, perfectParseResult);
// default +
addTestRow(default_ + final + property_var_p, perfectParseResult);
addTestRow(default_ + required + property_var_p, perfectParseResult);
/* default + readonly is contradictory because readonly prevents external assignment,
* while default implies the property is the target for implicit
* external assignments - so a readonly property can't logically be the default */
addTestRow(default_ + readonly + property_var_p + colon_1,
ParseResult{ true,
diagnosticMsg("Readonly prevents re-assignment, hence there is no "
"use for default") });
// readonly +
addTestRow(readonly + final + property_var_p + colon_1, perfectParseResult);
// if property is readonly, a.k.a. already initialized, there is no use of marking it
// required
addTestRow(
readonly + required + property_var_p + colon_1,
ParseResult{
true,
diagnosticMsg("Required properties with initializer do not make sense.") });
// required +
addTestRow(required + final + property_var_p, perfectParseResult);
addTestRow(required + default_ + property_var_p, perfectParseResult);
addTestRow(final + required + default_ + property_var_p, perfectParseResult);
addTestRow(
override_ + virtual_ + property_var_p,
ParseResult{ true,
diagnosticMsg(
"'virtual' is redundant when overriding a property. "
"The 'override' must only be used when actually overriding an "
"existing property; using it on a "
"new property is an error.") });
addTestRow(
virtual_ + override_ + property_var_p,
ParseResult{
true,
diagnosticMsg(
"'virtual' is redundant when overriding a property. The 'override' "
"must only be used when actually overriding an existing property; "
"using it on a "
"new property is an error.") });
addTestRow(final + virtual_ + property_var_p,
ParseResult{ true,
diagnosticMsg("The 'virtual' cannot be combined with 'final', as "
"these attributes are mutually exclusive") });
addTestRow(virtual_ + final + property_var_p,
ParseResult{ true,
diagnosticMsg("The 'virtual' cannot be combined with 'final', as "
"these attributes are mutually exclusive") });
addTestRow(
override_ + final + property_var_p,
ParseResult{
true,
diagnosticMsg(
"'override' is redundant when a property is marked as 'final'") });
addTestRow(
final + override_ + property_var_p,
ParseResult{
true,
diagnosticMsg(
"'override' is redundant when a property is marked as 'final'") });
}
}
/*
This test verifies that the QML parser correctly recognizes and validates property declarations
with various combinations of modifiers (default, readonly, required, final, virtual, override) and
syntactic constructs. It ensures that the parser both accepts valid property definitions and
produces appropriate diagnostics for invalid or illogical combinations.
*/
void tst_qqmlparser::propertyDeclarations()
{
QFETCH(QString, propertyDeclaration);
QFETCH(ParseResult, expectedParseResult);
const ParseResult actualParseResult = parseAs(SyntaxKind::UiObjectMember, propertyDeclaration);
QCOMPARE(actualParseResult.success, expectedParseResult.success);
// For the purposes of these tests comparing only message and type is enough
QCOMPARE(actualParseResult.diagnosticMessage.type, expectedParseResult.diagnosticMessage.type);
QEXPECT_FAIL("default readonly property var p : 1 ", "A Warning is to be implemented",
Continue);
QCOMPARE(actualParseResult.diagnosticMessage.message,
expectedParseResult.diagnosticMessage.message);
}
/*
This test verifies that the QML parser correctly constructs and populates the corresponding AST
node (UiPublicMember) for QML property declarations, ensuring that modifier tokens (such as
final, virtual, and override) are accurately represented in the resulting node.
*/
void tst_qqmlparser::propertyDeclarationsAST()
{
using namespace QQmlJS::AST;
using namespace Syntax;
// For the purposes of this test variables of Phrase type are divirging from camelCase
// this is made for the puposes of them matching closely the end-result test strings,
// e.g. property_var_p -> "property var p"
const QLatin1StringView propName("p");
const Phrase property_var_p = { Token::T_PROPERTY, Token::T_VAR, propName };
{
const auto *actualPublicMember = cast<const UiPublicMember *>(
parseAs(SyntaxKind::UiObjectMember, toString(property_var_p)).rootNode);
QCOMPARE(actualPublicMember->name, propName);
QCOMPARE(actualPublicMember->isDefaultMember(), false);
QCOMPARE(actualPublicMember->isFinal(), false);
QCOMPARE(actualPublicMember->isRequired(), false);
QCOMPARE(actualPublicMember->isReadonly(), false);
QCOMPARE(actualPublicMember->isOverride(), false);
QCOMPARE(actualPublicMember->isVirtual(), false);
}
{
const Word virtual_(Token::T_VIRTUAL);
const auto *actualPublicMember = cast<const UiPublicMember *>(
parseAs(SyntaxKind::UiObjectMember, toString(virtual_ + property_var_p)).rootNode);
QCOMPARE(actualPublicMember->isVirtual(), true);
QCOMPARE(actualPublicMember->name, propName);
QCOMPARE(actualPublicMember->isDefaultMember(), false);
QCOMPARE(actualPublicMember->isFinal(), false);
QCOMPARE(actualPublicMember->isRequired(), false);
QCOMPARE(actualPublicMember->isReadonly(), false);
QCOMPARE(actualPublicMember->isOverride(), false);
const QQmlJS::SourceLocation expectedLocation(0, stringView(virtual_).size(), 1, 1);
QCOMPARE(actualPublicMember->virtualToken(), expectedLocation);
}
{
const Word override_(Token::T_OVERRIDE);
const auto *actualPublicMember = cast<const UiPublicMember *>(
parseAs(SyntaxKind::UiObjectMember, toString(override_ + property_var_p)).rootNode);
QCOMPARE(actualPublicMember->isOverride(), true);
QCOMPARE(actualPublicMember->name, propName);
QCOMPARE(actualPublicMember->isDefaultMember(), false);
QCOMPARE(actualPublicMember->isFinal(), false);
QCOMPARE(actualPublicMember->isRequired(), false);
QCOMPARE(actualPublicMember->isReadonly(), false);
QCOMPARE(actualPublicMember->isVirtual(), false);
const QQmlJS::SourceLocation expectedLocation(0, stringView(override_).size(), 1, 1);
QCOMPARE(actualPublicMember->overrideToken(), expectedLocation);
}
{
const Word final_(Token::T_FINAL);
const Word readonly(Token::T_READONLY);
const auto *actualPublicMember = cast<const UiPublicMember *>(
parseAs(SyntaxKind::UiObjectMember, toString(final_ + readonly + property_var_p))
.rootNode);
QCOMPARE(actualPublicMember->isReadonly(), true);
QCOMPARE(actualPublicMember->isFinal(), true);
QCOMPARE(actualPublicMember->name, propName);
QCOMPARE(actualPublicMember->isDefaultMember(), false);
QCOMPARE(actualPublicMember->isRequired(), false);
QCOMPARE(actualPublicMember->isOverride(), false);
QCOMPARE(actualPublicMember->isVirtual(), false);
const quint32 lineNum = 1;
const QQmlJS::SourceLocation finalTokenLocation(0, stringView(final_).size(), lineNum, 1);
QCOMPARE(actualPublicMember->finalToken(), finalTokenLocation);
const quint32 overrideTokenOffset = finalTokenLocation.end() + 1;
const QQmlJS::SourceLocation readonlyTokenLocation(
overrideTokenOffset, stringView(readonly).size(), lineNum, overrideTokenOffset + 1);
QCOMPARE(actualPublicMember->readonlyToken(), readonlyTokenLocation);
}
}
void tst_qqmlparser::trailingCommaInUiArray()
{
QFile file(testFile("trailingComma.qml"));
QVERIFY(file.open(QIODevice::ReadOnly));
QQmlJS::Engine engine;
QQmlJS::Lexer lexer(&engine);
lexer.setCode(file.readAll(), 1);
QQmlJS::Parser parser(&engine);
QVERIFY(parser.parse());
}
QTEST_MAIN(tst_qqmlparser)
#include "tst_qqmlparser.moc"
|