-
-
Notifications
You must be signed in to change notification settings - Fork 541
feat: build IDE2 on darwin arm64 #1577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
045e80f to
2876a51
Compare
ae8baa4 to
5ac6801
Compare
- Use Node.js 16+, - All workflow files use `.yml` instead of `.yaml`, - Use Arduino LS `0.7.2`, - Updated `electron-builder` to `23.3.3`, - Removed unused `conf-node-gyp.sh`, - Removed unused `THEIA_ELECTRON_SKIP_REPLACE_FFMPEG`, and - Aligned `node-gyp@9.3.0`, `electron-rebuild@3.2.9` to Theia. Co-authored-by: per1234 <accounts@perglass.com> Co-authored-by: Akos Kitta <a.kitta@arduino.cc> Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
|
@ubidefeo, could you please help with the review? Thank you! |
|
@kittaakos |
ubidefeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App builds flawlessly on Mac OS Monterey on M1 Max.
It also behaves extremely well and is faster than expected.
I approve
Motivation
Devs can build the IDE2 on macOS with an M1 chip.
Change description
.ymlinstead of.yaml,0.7.2,electron-builderto23.3.3,conf-node-gyp.sh,THEIA_ELECTRON_SKIP_REPLACE_FFMPEG, andnode-gyp@9.3.0,electron-rebuild@3.2.9to Theia.Verified with the following build steps:
Click to see full build output on macOS M1
IDE2 build from this PR is running on M1 (process kind is
Appleinstead ofIntel):About dialog on M1:
IDE2
2.0.0is running on M1 withIntelprocess kind:Other information
This PR is not about supporting the M1 build via GH Actions. See #408 (comment). This PR is solely to enable building and packaging the IDE2 on M1.
This PR depends on #1571.✅Reviewer checklist