Update ls release version automatically using ldflags #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbfbd87 to
472faa4
Compare
umbynos
reviewed
Oct 19, 2022
umbynos
reviewed
Oct 19, 2022
umbynos
reviewed
Oct 19, 2022
umbynos
suggested changes
Oct 19, 2022
Contributor
umbynos
left a comment
There was a problem hiding this comment.
I think we can remove the i18n stuff
24f2cbe to
9f13303
Compare
umbynos
approved these changes
Oct 19, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
What kind of change does this PR introduce?
Infrastructure enhancement
What is the current behavior?
The Language Server's version (ServerInfo) has to be manually set to the new one during the release process.
What is the new behavior?
The Language Server's version will be automatically updated using
ldflags. The version will also be printed in the log when a new Arduino Language Server is configured.The changes were tested in this release: https://github.com/MatteoPologruto/arduino-language-server/releases/tag/99.99.99