feat(pubsub): add support for cloud storage subscriptions #7977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-pubsub-storage-subscriptions
shollyman
reviewed
Jun 1, 2023
lahuang4
reviewed
Jun 15, 2023
lahuang4
approved these changes
Jun 16, 2023
shollyman
approved these changes
Jun 21, 2023
| } | ||
|
|
||
| case "cloud_storage_config": | ||
| sub.proto.CloudStorageConfig = req.GetSubscription().GetCloudStorageConfig() |
Contributor
There was a problem hiding this comment.
there's some invariant here that ensures req.GetSubscription() doesn't return nil?
Member
Author
There was a problem hiding this comment.
Correct, it's checked in the first lines above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for subscriptions that pushes messages to Cloud Storage.