Skip to content

feat(pubsub): add support for cloud storage subscriptions #7977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 23, 2023
Merged

feat(pubsub): add support for cloud storage subscriptions #7977

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e65bbb8
feat(pubsub): add support for cloud storage subscriptions
hongalex May 22, 2023
b52316c
Merge branch 'main' into feat-pubsub-storage-subscriptions
hongalex May 22, 2023
c7b8063
Merge branch 'main' of github.com:googleapis/google-cloud-go into fea…
hongalex May 23, 2023
b7708bc
Merge branch 'main' into feat-pubsub-storage-subscriptions
hongalex May 24, 2023
f4700e1
Merge branch 'main' into feat-pubsub-storage-subscriptions
hongalex May 25, 2023
cbe3726
fix exported type style
hongalex May 26, 2023
071fc70
Merge branch 'main' into feat-pubsub-storage-subscriptions
hongalex May 26, 2023
a6b3e8e
fix bad sentinel value in gcs and bq subs
hongalex Jun 1, 2023
e8a0eb3
make cloud subscription fake behavior consistent with live service
hongalex Jun 12, 2023
9c60ad2
Merge branch 'main' into feat-pubsub-storage-subscriptions
hongalex Jun 12, 2023
24f78dd
Merge branch 'main' into feat-pubsub-storage-subscriptions
hongalex Jun 12, 2023
15164e9
Merge branch 'main' of github.com:googleapis/google-cloud-go into fea…
hongalex Jun 15, 2023
5d0a7c8
address review comments
hongalex Jun 15, 2023
725858e
revert change that erroneously deletes bq config check
hongalex Jun 15, 2023
82e8bfd
Merge branch 'main' into feat-pubsub-storage-subscriptions
hongalex Jun 23, 2023
40655f1
fix wording in one of comment
hongalex Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert change that erroneously deletes bq config check
  • Loading branch information
@hongalex
hongalex committed Jun 15, 2023
commit 725858e05c31d2c802795cba7bc9a72bf4a239c5
1 change: 1 addition & 0 deletions pubsub/pstest/fake.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,7 @@ func (s *GServer) UpdateSubscription(_ context.Context, req *pb.UpdateSubscripti
case "bigquery_config":
// If bq config is nil here, it will be cleared.
// Otherwise, we'll consider the subscription active if any table is set.
sub.proto.BigqueryConfig = req.GetSubscription().GetBigqueryConfig()
if sub.proto.GetBigqueryConfig() != nil {
if sub.proto.GetBigqueryConfig().GetTable() != "" {
sub.proto.BigqueryConfig.State = pb.BigQueryConfig_ACTIVE
Expand Down