Update TypeScript to 2.6 #16
Conversation
TypeScript will complain about: "Type 'Node' is not assignable to type 'SourceFile'."
ts.NodeArray now is ReadonlyArray, helper functions should accept ArrayLike arguments.
| ]; | ||
|
|
||
| export type TransformFactoryFactory = (typeChecker: ts.TypeChecker) => ts.TransformerFactory<ts.Node>; | ||
| export type TransformFactoryFactory = (typeChecker: ts.TypeChecker) => ts.TransformerFactory<ts.SourceFile>; |
There was a problem hiding this comment.
TypeScript will complain it if we use <ts.Node> here.
| */ | ||
| export function insertBefore<T>(collection: T[], beforeItem: T, newItem: T) { | ||
| const index = collection.indexOf(beforeItem); | ||
| export function insertBefore<T>(collection: ArrayLike<T>, beforeItem: T, newItems: T | T[]) { |
There was a problem hiding this comment.
We need use ArrayLike type now because ts.NodeArray now is ReadonlyArray.
src/helpers/index.ts
Outdated
| } | ||
| export { find }; | ||
|
|
||
| // export const has = some |
src/helpers/index.ts
Outdated
|
|
||
| return false; | ||
| } | ||
| export { find }; |
There was a problem hiding this comment.
Lets use find imported from loads where it is needed
src/helpers/index.ts
Outdated
| import * as kinds from './isKind'; | ||
|
|
||
| export * from './isKind'; | ||
| import { find, indexOf, slice } from 'lodash'; |
There was a problem hiding this comment.
we're using namespace imports in this project
import * as _ from 'lodash'| ) { | ||
| const allMembers = node.type.types | ||
| .map((type: ts.TypeLiteralNode) => type.members) | ||
| const allMembers = (node.type.types as ts.NodeArray<ts.TypeLiteralNode>) |
There was a problem hiding this comment.
Why we have to cast to ts.NodeArray<ts.TypeLiteralNode> here?
There was a problem hiding this comment.
Because TypeScript can't figure out the previous node.type.types.every(...), and still think the type of node.type.types is ts.NodeArray<ts.TypeNode>, rather than ts.NodeArray<ts.TypeLiteralNode>.
I can add a comment here.
There was a problem hiding this comment.
ok I think casting should be fine for now. I'll dig deeper into it soon.
|
A few notes, otherwise looks good! Thanks! |
I split this into multiple commits for easier reviewing. You can view commits one by one.