MAINT: Replace plt.<cmd> pattern with explicit fig/ax calls
#295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My understanding is that explicit figure/axis creation is the recommended pattern for
pyploton the basis of "explicit-over-implicit". Since one of the goals of numpy-tutorials is to highlight best-practices for scientific programming, I figured it'd be worthwhile to attempt to emphasize the OO pattern as opposed to the implicit fig/ax creation fromplt.imshow,plt.plot, etc.I don't have strong feelings though - I'm curious to what degree (if any) mpl folks would view this as an improvement @ksunden.