-
-
Notifications
You must be signed in to change notification settings - Fork 296
Hooks rewrite and increased test coverage #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ed QueryBuilder tests
Codecov Report
@@ Coverage Diff @@
## master #87 +/- ##
=========================================
+ Coverage 78.84% 100% +21.15%
=========================================
Files 7 11 +4
Lines 156 169 +13
Branches 24 9 -15
=========================================
+ Hits 123 169 +46
+ Misses 32 0 -32
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
pavanpodila
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
|
Thanks, @pavanpodila! I went ahead and merged this into master. Can you publish a new version on npm? It may need a major version bump since it now requires React >= 16.8. |
|
Done: https://www.npmjs.com/package/react-querybuilder. Thanks for the great work Jake! 🚀 |
This PR rewrites react-querybuilder to use React Hooks. It also increases test coverage to 100% and avoids warnings in React 16.9 about unsafe lifecycle methods.
This library will not be compatible with React 17 without changing the lifecycle names to "UNSAFE_*", so some change is necessary anyway. Might as well future-proof it with Hooks.