Skip to content

Correct return type to CustomElementConstructor #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Correct return type to CustomElementConstructor #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ import _Vue, { Component, AsyncComponent } from 'vue'
declare function wrap(
Vue: typeof _Vue,
Component: Component | AsyncComponent
): HTMLElement
): CustomElementConstructor
Copy link

@bghandou bghandou Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
): CustomElementConstructor
): typeof HTMLElement

This will fix the return typing issue, and also is more accurate. Here is why:
wrap() function returns this, which is indeed a type of HTMLElement. This type declaration will indeed fix the lack of congruency.


export default wrap