Bash script how to execute a command from a variable

Question

I am trying to alter the Bash function below to execute each command argument. But when I run this script, the first echo works as intended, but the second echo that attempts to append to the scratch.txt file does not actually execute. It just gets echo'd into the prompt.

#!/bin/sh
clear

function each(){
  while read line; do
    for cmd in "$@"; do
      cmd=${cmd//%/$line}
      printf "%s\n" "$cmd"
      $cmd
    done
  done
}

# pipe in the text file and run both commands
# on each line of the file
cat scratch.txt | each 'echo %' 'echo -e "%" >> "scratch.txt"'

exit 0

How do I get the $cmd variable to execute as a command?

I found the original code from answer 2 here: Running multiple commands with xargs

ghoti · Accepted Answer · 2012-11-10 16:31:36Z

6

You want eval. It's evil. Or at least, dangerous. Read all about it at BashFAQ #48.

answered Nov 10, 2012 at 16:31

ghoti

47.2k8 gold badges71 silver badges108 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Peter Mortensen Over a year ago

Re "You want eval": Do you mean "You don't want eval"? Or "You want eval, but"? Or something else?

Collectives™ on Stack Overflow

Bash script how to execute a command from a variable

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related