Javascript only producing last value of json encoded array

Question

here's the PHP/PDO.

    try {





    $query = 'SELECT Date,Close FROM DY_AAPL LIMIT 5';


    $sth = $db->prepare($query);
    $sth->execute();


    while ($row = $sth->fetch(PDO::FETCH_ASSOC)){

        $result_array=array();
        $result_array[]=$row['Close'];

    /*    $num = $row['Close'];    */

        echo json_encode($result_array);



    }


    }catch (PDOException $e){

        echo 'ERROR ' . $e->getMessage();
    }

When I attempt to access the array using javascript, it's only outputting the last value in the array. Any pointers?

    <script type="text/javascript">

       var myjson = JSON.parse('<?php echo json_encode($result_array); ?>');

        document.write(myjson); 

    </script>

I thought it might have something to do with 'JSON.parse,' but I'm not sure. Thanks in advance!

There's no reason to use JSON.parse() like that. You can just drop the JSON directly into the JavaScript source as the value of the "myjson" variable. — Pointy
– Pointy, Commented Jan 28, 2013 at 21:28
Pointy, if I wanted to pass the JSON to an array, would the variable simply be - "var myjson = [<?php echo json_encode($result_array); ?>];" — spm
– spm, Commented Jan 28, 2013 at 21:39
If you wanted to put the object value inside a JavaScript array, then yes. — Pointy
– Pointy, Commented Jan 28, 2013 at 21:52

Bergi · Accepted Answer · 2013-01-28 21:29:46Z

1

Try

$result_array = array();

while ($row = $sth->fetch(PDO::FETCH_ASSOC)) {

    $result_array[]=$row['Close'];

   /*    $num = $row['Close'];    */

}

echo json_encode($result_array);

…instead of initializing and outputting the array in each loop turn.

answered Jan 28, 2013 at 21:29

Bergi

671k162 gold badges1k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Green Black · Accepted Answer · 2013-01-28 21:28:14Z

0

You should echo your end result, not every iteration:

   while ($row = $sth->fetch(PDO::FETCH_ASSOC)){

        $result_array=array();
        $result_array[]=$row['Close'];


    }
 echo json_encode($result_array);

answered Jan 28, 2013 at 21:28

Green Black

5,0571 gold badge19 silver badges29 bronze badges

Comments

Jonathan M · Accepted Answer · 2013-01-28 21:30:54Z

0

Try this for your PHP:

    try {
        $query = 'SELECT Date,Close FROM DY_AAPL LIMIT 5';
        $sth = $db->prepare($query);
        $sth->execute();

        $result_array=array();
        while ($row = $sth->fetch(PDO::FETCH_ASSOC)){
            $result_array[]=$row['Close'];
        }
        echo json_encode($result_array);

    }catch (PDOException $e){

        echo 'ERROR ' . $e->getMessage();
    }

answered Jan 28, 2013 at 21:30

Jonathan M

17.5k9 gold badges61 silver badges95 bronze badges

Comments

Tommie · Accepted Answer · 2013-01-28 21:33:11Z

0

It's because your doing the json encode within the while-loop. Place it outside the loop so the entire array get encoded.

Also, you're initializing the array within the while-loop. Which means that it will overwrite itself each time it loops.

edited Jan 28, 2013 at 21:33

answered Jan 28, 2013 at 21:27

Tommie

1,9652 gold badges14 silver badges23 bronze badges

Collectives™ on Stack Overflow

Javascript only producing last value of json encoded array

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related