Improving a bash script with python

Question

How would I make the following less redundant? That is, is there a way to combine the two almost-identical statements into one?

FULFILLMENT="/Users/david/Desktop/pds" # "/Volumes/FulfilmentArray/"
ARCH1="/Users/david/Desktop/etc" # "/Volumes/Arch_01/"

FILE="/tmp/files.txt"

# find all the paths and print them to a file
sudo find $FULFILLMENT -ls | python -c '
import sys
for line in sys.stdin:
    r = line.strip("\n").split(None, 10)
    fn = r.pop()
    print ",".join(r) + ",\"" + fn.replace("\"", "\"\"") + "\""
' > $FILE &&

sudo find $ARCH1 -ls | python -c '
import sys
for line in sys.stdin:
    r = line.strip("\n").split(None, 10)
    fn = r.pop()
    print ",".join(r) + ",\"" + fn.replace("\"", "\"\"") + "\""
' >> $FILE

that other guy · Accepted Answer · 2013-01-29 19:48:21Z

4

Find can go through multiple directories in a single command:

FULFILLMENT="/Users/david/Desktop/pds" # "/Volumes/FulfilmentArray/"
ARCH1="/Users/david/Desktop/etc" # "/Volumes/Arch_01/"

FILE="/tmp/files.txt"

# find all the paths and print them to a file
sudo find "$FULFILLMENT" "$ARCH1" -ls | python -c '
import sys
for line in sys.stdin:
    r = line.strip("\n").split(None, 10)
    fn = r.pop()
    print ",".join(r) + ",\"" + fn.replace("\"", "\"\"") + "\""
' > $FILE

answered Jan 29, 2013 at 19:48

that other guy

125k12 gold badges187 silver badges214 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

David542 Over a year ago

Thanks, and this will do a recursive find on all the subdirectories in the main directory as well?

that other guy Over a year ago

Yes, it will go through every dir under $FULFILLMENT and $ARCH1

William Pursell · Accepted Answer · 2013-01-29 20:15:46Z

1

You can do:

cmd='
import sys
for line in sys.stdin:
    r = line.strip("\n").split(None, 10)
    fn = r.pop()
    print ",".join(r) + ",\"" + fn.replace("\"", "\"\"") + "\""
'
sudo find $FULFILLMENT -ls | python -c "$cmd" >> $FILE
sudo find $ARCH1 -ls | python -c "$cmd" >> $FILE

answered Jan 29, 2013 at 20:15

William Pursell

214k49 gold badges279 silver badges317 bronze badges

Comments

William Pursell · Accepted Answer · 2013-01-29 21:15:42Z

1

Although the output of the following is slightly different, I suspect you would be happier with:

FULFILLMENT=/Users/david/Desktop/pds
ARCH1=/Users/david/Desktop/etc
exec > /tmp/files.txt

find $FULFILLMENT $ARCH1 -exec stat -c '%i,%b,%A,%h,%U,%G,%y,%n' {} \;

The format of the date is different, and stat may report a different blocksize if you are not invoking find with POSIXLY_CORRECT. This does not attempt to escape quotes in the filename nor to put the filename in quotes since you are clearly not worried about filenames which may contain a comma, so we can assume the output can be parsed reliably as csv and not worry about the quotes.

answered Jan 29, 2013 at 21:15

William Pursell

214k49 gold badges279 silver badges317 bronze badges

Collectives™ on Stack Overflow

Improving a bash script with python

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related