add/combine json array to array in JSON file php

Question

I have been trying to solve this problem for the better part of two days with no success. I am trying combine/add to a json array that is stored in a .json file on my server using php.

This is a short version of what I'm trying to combine.

box.json:

[{"date":"25.4.2013 10:40:10"},{"comment":"some text"},{"comment":"some more text"}]

posted json:

[{"date":"25.4.2013 10:45:15"},{"comment":"another quote"},{"comment":"quote"}]

This is what I need.

[{"date":"25.4.2013 10:40:10"},{"comment":"some text"},{"comment":"some more text"},
{"date":"25.4.2013 10:45:15"},{"comment":"another quote"},{"comment":"quote"}]

This is what I get. (an array inside an array)

[{"date":"25.4.2013 10:40:10"},{"comment":"some text"},{"comment":"some more text"},
[{"date":"25.4.2013 10:45:15"},{"comment":"another quote"},{"comment":"quote"}]]

This is my code:

<?php
$sentArray = $_POST['json'];
$boxArray = file_get_contents('ajax/box.json');
$sentdata = json_decode($sentArray);
$getdata = json_decode($boxArray);
$sentdata[] = $getdata;   /* I also tried array_push($sentdata, $getdata); */
$json = json_encode($sentdata);
$fsize = filesize('ajax/box.json');
if ($fsize <= 5000){
    if (json_encode($json) != null) { /* sanity check */
    $file = fopen('ajax/box.json' ,'w+');
    fwrite($file, $json);
    fclose($file);
}else{
    /*rest of code*/
}
?>

Please help my sanity is starting to come in to question.

Ali Akbar Azizi · Accepted Answer · 2013-04-25 19:16:54Z

1

here is your problem

$sentdata[] = $getdata;

use foreach

foreach($getdata as $value)
    $sentdata[] = $value;

UPDATE: but i think you need this for $sentdata not $getdata

foreach($senttdata as $value)
    $getdata[] = $value;

then put $getdata to your file.

answered Apr 25, 2013 at 19:16

Ali Akbar Azizi

3,5654 gold badges31 silver badges50 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

Madbreaks Over a year ago

Iteration is not the best answer here - depending on the size of the data set this could become very expensive.

Ali Akbar Azizi Over a year ago

@Madbreaks is there a any other way ? what is array_merge exactly do ? just write a name , and your code is best ? what is this function exactly do ?

Madbreaks Over a year ago

I explained what array_merge does. I also provided a link to the official PHP docs. Is that not sufficient?

unsalted Over a year ago

data set will write over at 5kb, would it be a problem?

Madbreaks Over a year ago

It will be extremely inefficient - this is what's called a brute-force solution.

Shu · Accepted Answer · 2013-04-25 19:29:32Z

1

$box = json_decode(file_get_contents('ajax/box.json'));
$posted = json_decode($_POST['json']);
$merge = array_merge ((array)$box,(array)$posted);

Casting (array) prevent error if $box or $posted become null or false, it will be an empty array

answered Apr 25, 2013 at 19:29

Shu

111 bronze badge

Comments

Madbreaks · Accepted Answer · 2013-04-25 19:24:10Z

0

Instead of this:

$sentdata[] = $getdata;   /* I also tried array_push($sentdata, $getdata); */

Try:

$combinedData = array_merge($sentData, $getData);
$json = json_encode($combinedData);

By using array_merge you're combining the arrays into one instead of adding one array as a value into the other.

Note that I changed the name of your resulting data - try to avoid variables with the same name and different capitalization, it will make things much easier to understand (for you and for future developers supporting your code).

Cheers

edited Apr 25, 2013 at 19:24

answered Apr 25, 2013 at 19:17

Madbreaks

19.6k7 gold badges62 silver badges75 bronze badges

3 Comments

unsalted Over a year ago

I need to add values, It should allow for duplicates. And you are right my my naming practices are messy. I'm a designer learning to develop. Thanks for the advice.

Madbreaks Over a year ago

Nick, it will allow for duplicates since you are using Objects as values and not scalars. Let me know if it's unclear how to use this.

unsalted Over a year ago

I tried running array merge awhile ago and it didn't work (I must have done something wrong), but it appears you are correct it works now. Thanks!

Collectives™ on Stack Overflow

add/combine json array to array in JSON file php

3 Answers 3

5 Comments

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

5 Comments

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related