PHP - combine function that returns array into another array

Question

I'm working with an OpenCart store that's based on an mcv design pattern. I need have a model function that returns an array but I need to make a call within that array to another function that returns an array. This function below breaks here:

'gallery_images' => $this->getGalleryImages($data['product_id'])

public function getImportProductInfo() {
    $query = $this->db->query("SELECT `product_id` FROM " . DB_PREFIX . "product WHERE `status` = '0' AND `affiliate_id` = '" . $this->affiliate->getID() . "'");   

    $pids = array();
    foreach($query->rows as $result) {
        $pids[] = $result['product_id'];
    }

    // product & product description
    $query_product = $this->db->query("SELECT    p.model,
                                                 p.product_id,
                                                 p.quantity,
                                                 p.image,
                                                 p.price,
                                                 p.weight,
                                                 p.length,
                                                 p.width,
                                                 p.height,
                                                 pd.name AS 'product_name',
                                                 pd.description AS 'product_description',
                                                 cd.name AS `category_name`,
                                                 m.name AS 'manufacturer_name'
                                      FROM       " . DB_PREFIX . "product p
                                      LEFT JOIN  " . DB_PREFIX . "product_description pd ON p.product_id = pd.product_id
                                      LEFT JOIN  " . DB_PREFIX . "product_to_category ptc ON p.product_id = ptc.product_id
                                      LEFT JOIN  " . DB_PREFIX . "category_description cd ON ptc.category_id = cd.category_id
                                      LEFT JOIN  " . DB_PREFIX . "manufacturer m ON p.manufacturer_id = m.manufacturer_id
                                      WHERE      p.product_id IN (" . $this->db->escape(implode(',',$pids)) . ")");


    foreach($query_product->rows as $data) {
            $product_data[] = array(
              'product_id'           => $data['product_id'],
              'model'                => $data['model'],
              'quantity'             => $data['quantity'],
              'featured_image'       => $data['image'],
              'price'                => $data['price'],
              'weight'               => $data['weight'],
              'length'               => $data['length'],
              'width'                => $data['width'],
              'height'               => $data['height'],
              'product_name'         => $data['product_name'],
              'description'          => $data['product_description'],
              'category_name'        => $data['category_name'],
              'manufacturer_name'    => $data['manufacturer_name'],
              'gallery_images'       => array($this->getGalleryImages($data['product_id'])) 

            );      
    }

    return $product_data;
}

Here is the getGalleryImages() function. Note here I have also tried return implode(', ',$images); so i dont have to build the array but it still breaks.

public function getProductGalleryImages($product_id) {
    $query = $this->db->query("SELECT `image` FROM " . DB_PREFIX . "product_image WHERE `product_id` = '" . (int)$product_id . "'");

    $images = array();
    foreach($query->rows as $result) {
        $images[] = $result['image'];   
    }

    //return implode(', ',$images);
      return $images;
}

each product has multiple image urls stored in an intersecting table and I need to add to the array and it's been fighting me all morning... Any Ideas would be greatly appreciated. Thanks in advance :)

OK here is the sql embedded in the array that worked

'gallery_images' => $this->db->query("SELECT `image` FROM " . DB_PREFIX . "product_image WHERE `product_id` = '" . (int)$data['product_id'] . "'")

BUT it returns this:

[gallery_images] => stdClass Object ( 
[row] => Array ( [image] => motorcycle/12_06_27/031.JPG ) 
    [rows] => Array ( [0] => Array ( [image] => motorcycle/12_06_27/031.JPG ) )[num_rows] => 1 ) ) )

All I want is the ['image'] part.

dkellner · Accepted Answer · 2013-12-13 16:52:12Z

3

Just omit the "array" part. Instead of

array($this->getGalleryImages($data['product_id']))

use

$this->getGalleryImages($data['product_id'])

Since (and if) this function will return an array, this is the correct syntax. If you want to be safe about the returning value to be an array (that is, force it to be), you can do this:

array() $this->getGalleryImages($data['product_id'])

...which is ALMOST the same thing but notice that array() bracket is immediately closed. It means you "typecast" the result to an array. (I wonder if this was your original intention btw...?)

You can use arrays in arrays, there's no problem with that. Now if this is not the right answer, let's clarify the question itself :)

answered Dec 13, 2013 at 16:52

dkellner

10.2k3 gold badges54 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

9 Comments

handmdmr Over a year ago

@dkelliner So, your answers are correct towards my question but I have already tried all of those scenarios and they still break which is why I'm confused. If I embed the sql directly within the array it works but It returns a bunch of stuff I don't need also. I have added to the code above to show you my results.

dkellner Over a year ago

Tell me it's not "getProductGalleryImages" vs "getGalleryImages" :)

dkellner Over a year ago

(Also, you're doing a query inside a query which is not very healthy for your speed. There are other ways. But that's another question.)

dkellner Over a year ago

What does it mean "it breaks", btw? Is it some error message or just an empty result?

dkellner Over a year ago

That must be an error, it just gets redirected to some logfile. Can you access that? We need the error message if there is one.

|

Collectives™ on Stack Overflow

PHP - combine function that returns array into another array

1 Answer 1

9 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

9 Comments

Your Answer

Sign up or log in

Post as a guest

Related