I have javascript function that add numbers to array

Question

I have javascript function that add numbers to array start form min to max and increase by step but when I use getNumbers(2, 20, 2); it print 2,22,222,2222,.... It doesn't increase can anyone help me please.

        function getNumbers(min, max, step) {
               var i;
              for(i=min ; i<max ; i+=step){
               array.push(i);
               alert(array);
            }

yes if you will give arguments as strings then this problem will come, because the statement i+=step so "2"+="2" will return 22 after that 222 and so on. — Mritunjay
– Mritunjay, Commented Aug 29, 2014 at 10:03

Abdul Jabbar · Accepted Answer · 2014-08-29 10:09:38Z

2

Nothing wrong with your function, you must pass numbers, if the passing parameters are string, change them to numbers as i did below:

var array = new Array();
function getNumbers (min, max, step) {
              var i;
              for(i=min ; i<max ; i+=step){
               array.push(i);
               alert(array);
              }
}
//passing numbers:
getNumbers(1, 10, 2);
//output is 1,3,5,7,9

//if your numbers are strings, use:
var min = '1';
var max = '10';
var step = '2';
getNumbers(parseInt(min), parseInt(max), parseInt(step));
//this will work correctly

DEMO

answered Aug 29, 2014 at 10:09

Abdul Jabbar

2,5736 gold badges28 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

koninos · Accepted Answer · 2014-08-29 10:06:16Z

0

Use parseInt to cast to integers

answered Aug 29, 2014 at 10:06

koninos

5,4275 gold badges33 silver badges50 bronze badges

Comments

Flati · Accepted Answer · 2014-08-29 10:14:34Z

0

I see no problem with the function. Other than the array is not defined.

You're probably sending the variables in as a string, which causes concatenation instead of addition.

function getNumbers(min, max, step) {
    var array = [];
    for(var i = min ; i <= max ; i += step){
        array.push(i);
    }
    return array;
}

You might also need to make sure that you use i <= max in your loop, if you want to include the max.

answered Aug 29, 2014 at 10:14

Flati

1982 silver badges10 bronze badges

Collectives™ on Stack Overflow

I have javascript function that add numbers to array

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related