Implode string and insert into array?

Question

I can't get the implode function to work with my array. I'm building a site and every time you reload the page the background image is randomly chosen.

I have a loop with different image url:s like this:

<?php 
if( have_rows('pictures', 'option') ):
    while ( have_rows('pictures', 'option') ) : the_row();
        $pictures[] = get_sub_field('picture'); 
        $picturesimploded = "'" . implode("', '", $pictures) . "'";
    endwhile;
endif; 
?>

Below is the code to randomize which url is chosen:

<?php   
    $bg = array( $picturesimploded ); // array of filenames
    $i = rand(0, count($bg)-1); // generate random number size of the array
    $selectedBg = "$bg[$i]"; // set variable equal to which random filename was chosen
?>

The url is then applied to a div:

<div style="background-image: url( <?php echo $selectedBg; ?> );">

The output however prints all links:

<div style="background-image: url( 'http://example.com/image1', 'http://example.com/image1', 'http://example.com/image1' );">

It seems like the array can't separate the arrays. When I insert the links manually, directly, in the array like this it works:

<?php   
    $bg = array( 'http://example.com/image1', 'http://example.com/image1', 'http://example.com/image1' ); // array of filenames
    $i = rand(0, count($bg)-1); // generate random number size of the array
    $selectedBg = "$bg[$i]"; // set variable equal to which random filename was chosen
?>

Any ideas how to get the randomizing to work?

Jonathan · Accepted Answer · 2014-10-05 11:17:32Z

1

replace

$bg = array( $picturesimploded );

with

$bg = explode( $picturesimploded );

-- when you call

$bg = array( $picturesimploded );

you are making an array with one entry like this:

[0] => 'image,image,image,image,image'

when you use explode it will be like this

[0] => image,
[1] => image,

etc

an alternative would be to do this:

<?php 
$pictures = array();
if( have_rows('pictures', 'option') ):
    while ( have_rows('pictures', 'option') ) : the_row();
        $pictures[] = get_sub_field('picture'); 
    endwhile
endif; 

$i = rand(0, count($pictures)-1); // generate random number size of the array
$selectedBg = $pictures[$i]; // set variable equal to which random filename was chosen


?>

edited Oct 5, 2014 at 11:17

answered Oct 5, 2014 at 11:12

Jonathan

1,5643 gold badges16 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Felix Over a year ago

Your alternative way looks great! Is there a way of using wp_get_attachment_image_src($image_id, $image_size); instead of get_sub_field('picture');? I can't get it to work, and I assume the setup doesn't work with wp_get_attachment_image_src?

Jonathan Over a year ago

I use wp_get_attachment_image_src(get_post_thumbnail_id($post->ID), 'single-post-thumbnail'); -- but I'm not sure how you could work it into your code

Jens A. Koch · Accepted Answer · 2014-10-05 19:03:04Z

1

flip the array to work on values.
use array_rand with 1 to get 1 random element

Example: http://ideone.com/cpV2Va

<?php

$pictures = array();
if( have_rows('pictures', 'option') ):
    while ( have_rows('pictures', 'option') ) : the_row();
       $pictures[] = get_sub_field('picture'); 
    endwhile
endif; 

$selectedBg = array_rand(array_flip($pictures), 1);

edited Oct 5, 2014 at 19:03

answered Oct 5, 2014 at 11:17

Jens A. Koch

42.1k14 gold badges123 silver badges147 bronze badges

Collectives™ on Stack Overflow

Implode string and insert into array?

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related