Getting "Incorrect syntax near"-error with SqlDataReader

Question

I'm getting error and I don't know what's wrong with the code, so If anyone can help me I would be grateful.

Error:

Incorrect syntax near ','.

and the highlighted line is

rdr = cmd.ExecuteReader();

Code:

cn.Open();
string query = "SELECT * FROM dbo.ispiti WHERE poID=@poID, sgID=@sgID, npID=@npID";

SqlCommand cmd = new SqlCommand(query, cn);

cmd.Parameters.AddWithValue("@poID", pr);
cmd.Parameters.AddWithValue("@sgID", pr1);
cmd.Parameters.AddWithValue("@npID", pr2);

SqlDataReader rdr;

try
{
    rdr = cmd.ExecuteReader();

    if (rdr.Read())
    {
        MessageBox.Show("Well done!");
    }
}
catch(exception ex)
{
    MessageBox.Show("Error!");
}
finally
{
    cn.Close();
}

Chui Tey · Accepted Answer · 2015-06-17 14:18:50Z

8

There is an error in your SQL statement. You should change

string query = "SELECT * FROM dbo.ispiti WHERE poID=@poID, sgID=@sgID, npID=@npID";

to

string query = "SELECT * FROM dbo.ispiti WHERE poID=@poID AND sgID=@sgID AND npID=@npID";

answered Jun 17, 2015 at 14:18

Chui Tey

5,5842 gold badges41 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

oljko Over a year ago

M8 it took 1 minute for you to solve my problem on which I'm working whole afternoon. I overlooked the SQL statement part, and searched for problem elsewhere :) Thank you very much, I'll give you correct answer in 12 minutes (site doesn't allow me to accept answer sooner).

Soner Gönül · Accepted Answer · 2015-06-17 14:19:37Z

2

You can't use comma in WHERE clause. You need to use logical operations like AND or OR like;

WHERE poID=@poID AND sgID=@sgID AND npID=@npID

This clause takes search condition after it and there is no syntax for comma.

By the way, use using statement to dispose your connections, commands and readers automatically instead of calling Dispose or Close methods manually.

Also don't use AddWithValue method. It may generate unexpected results sometimes. Use Add method overloads to specify your parameter type and it's size.

answered Jun 17, 2015 at 14:19

Soner Gönül

99.1k103 gold badges224 silver badges375 bronze badges

Collectives™ on Stack Overflow

Getting "Incorrect syntax near"-error with SqlDataReader

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related