AngularJS - ng-click doesn't fire my controller function

Question

I am trying to call a function when my button is clicked. This code should work, but it doesn't fire the function I defined in my controller.

The code compile fine as show in the console, any idea?
Thanks!

This is my code:

  <html lang="en" ng-app="myApp" >
   <head>
   <meta charset="utf-8">
    <meta http-equiv="X-UA-Compatible" content="IE=edge">
    <meta name="viewport" content="width=device-width, initial-scale=1">
    <title>Ristorante Con Fusion</title>
    <!-- Bootstrap -->
    <script src="js/jquery-1.12.0.min.js"></script>
    <script src="js/angular.js"></script>
    <link href="css/bootstrap.min.css" rel="stylesheet">
   <link href="css/mystyles.css" rel="stylesheet">


<script >
var app = angular.module('myApp', []);

app.controller('navCtrl', function($scope) {


    $scope.select=function () {
        alert('hi');
    };
});
</script>
</head>
<body>

   <nav  id="mynav"class= "navbar navbar-inverse " role="navigation" ng-controller="navCtrl" > 
     <div class="container">

       <ul class="nav navbar-nav color-white ">
        <li  > 
          <a id="home" ng-click="navCtrl.select()"href="#" >home</a></li>
            <li >
              <a id="1" href="#" ng-click="navCtrl.select() ">About</a></li>
            <li >
               <a id="2" href="#" ng-click="navCtrl.select() ">Contact</a></li>
      </ul>


     </div>
   </nav>
</body>

I think you just need to use select() instead of navCtrl.select() — Vikram Kumar
– Vikram Kumar, Commented Jan 18, 2016 at 12:52

Martijn · Accepted Answer · 2016-01-18 12:54:11Z

3

You don't need to specify 'navCtrl' in your HTML. Just call 'ng-click=select()'. If you had used controller-as='navCtrl' then you need to use navCtrl.select.

answered Jan 18, 2016 at 12:54

Martijn

24.9k62 gold badges181 silver badges270 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Kunal Kakkad · Accepted Answer · 2016-01-18 12:55:20Z

0

Just modify it as follows:

<ul class="nav navbar-nav color-white ">
    <li  > 
       <a id="home" ng-click="select()">home</a></li>
     <li >
       <a id="1" href="#" ng-click="select()">About</a></li>
     <li >
       <a id="2" href="#" ng-click="select()">Contact</a></li>
</ul>

Hope it works.!

answered Jan 18, 2016 at 12:55

Kunal Kakkad

6516 silver badges20 bronze badges

Collectives™ on Stack Overflow

AngularJS - ng-click doesn't fire my controller function

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related