JavaScript : Split string using function and returning it

Question

I don't know what I'm doing wrong here. Tried several thinks but the function doesn't work/return properly (The html code is okay)

var divResult = document.getElementById("divResult");
var naam;

function splitsen(naam){
    var res = naam.split(" ");
    document.write(res[0]);
    var voornaam = res[0];
    var achternaam = res[1];
    var tnaam = [voornaam, achternaam];
return tnaam;
}

naam = parseInt(prompt("Geef je voornaam en achternaam in gescheiden met een spatie"));

var voornaam = splitsen(naam)[0];
var achternaam = splitsen(naam)[1];
divResult.innerHTML = "oefening 8";
divResult.innerHTML += "Voornaam: " + voornaam;
divResult.innerHTML += "Achternaam" + achternaam;
divResult.innerHTML += "Email: " + voornaam + "." + achternaam + "@student.arteveldehs.be";

well your function work it return 2 words in an array

Alex C
– Alex C

2016-03-02 20:00:52 +00:00
Commented Mar 2, 2016 at 20:00 — Alex C
– Alex C, Commented Mar 2, 2016 at 20:00

Max · Accepted Answer · 2016-03-02 20:01:30Z

1

parseInt('My Name'); returns NaN.

Remove the parseInt(), and just keep it as:

var naam = prompt('Input your name seperated by a space.');

edited Mar 2, 2016 at 20:01

answered Mar 2, 2016 at 19:59

Max

2,8562 gold badges27 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Max Over a year ago

No problem. If you would accept my answer, I'd be grateful.

Aiman Al-Eryani · Accepted Answer · 2016-03-02 20:06:30Z

0

I could spot 2 problems in your code:

1-The parameter name to your function is the same name as that of a global variable. It is probable that any references to 'naam' in your function use the global variable instead of what you pass. Regardless, don't do that.

2-parseInt will take a string and extract an integer out of it and returns a number. number types doesn't have the split() method and you probably wanted a string containing the name.

edited Mar 2, 2016 at 20:06

answered Mar 2, 2016 at 20:03

Aiman Al-Eryani

7094 silver badges19 bronze badges

7 Comments

Aiman Al-Eryani Over a year ago

@MaxMastalerz What are you talking about?

Max Over a year ago

Nevermind my first comment. What I meant to say is that the parameter name can be the same as the global variable. It won't matter.

Aiman Al-Eryani Over a year ago

Yes, but still. That can cause ambiguity from a developer's point of view.

Max Over a year ago

He doesn't even need a parameter. naam is a global, and therefore accessible in the function without it being passed in.

Aiman Al-Eryani Over a year ago

So, I see you agree using a global variable's name for a function parameter is bad.

|

Collectives™ on Stack Overflow

JavaScript : Split string using function and returning it

2 Answers 2

1 Comment

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related