Angular Js syntax error

Question

I've got the following factory:

(function() {
angular.module('temp')
    .factory('Factory',Factory);

    employeeFactory.$inject = ['$http'];
    function employeeFactory($http) {
        var factory = {};
        var vm = this;

        factory.login = function(email,password) {
            return $http({
                'method': 'POST',
                'url': 'http://domain.dev/api/v1/login',
                'data': $.param({
                    'email': email,
                    'password': password
                }),
                'headers': {
                    'Content-Type': 'application/x-www-form-urlencoded'
                }
            });
        return factory;
    }
})();

I receive the error:

Uncaught SyntaxError: Unexpected token )

The console refers to the last line:

})();

Quentin · Accepted Answer · 2016-03-22 12:26:06Z

5

Run your code through a code formatter to fix the whitespace. The problem becomes obvious.

(function() {
        angular.module('skindustries')
            .factory('employeeFactory', employeeFactory);

        employeeFactory.$inject = ['$http'];

        function employeeFactory($http) {
            var factory = {};
            var vm = this;

            factory.login = function(email, password) {
                return $http({
                    'method': 'POST',
                    'url': 'http://domain.dev/api/v1/login',
                    'data': $.param({
                        'email': email,
                        'password': password
                    }),
                    'headers': {
                        'Content-Type': 'application/x-www-form-urlencoded'
                    }
                });
                return factory;
            }
        })();

Your last }, which you are attempting to use to close the function expression that started on line 1 is actually closing the employeeFactory function.

You then need another } to close the function expression that started on line 1 before you can have a ) to match the ( that is the very first character of the script.

You probably want to put it before the return factory; statement as it looks like the missing } is the one belonging to the anonymous function you assign to factory.login.

answered Mar 22, 2016 at 12:26

Quentin

949k136 gold badges1.3k silver badges1.4k bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Jenish Rabadiya Over a year ago

what is the meaning of two return statement inside the factory.login?

Jamie Over a year ago

Thankyou that helped !

Simple-Solution Over a year ago

@JenishRabadiya - The first return essentially returns the resulting response from the POST request. whereas the second return; returns|exposes the factory and its associated api's publicly. So in above example, you're exposing the login(u,p) function to other components within your app when this service is injected as dependency in your controller|service etc.

Jenish Rabadiya Over a year ago

@Simple-Solution No. That's not correct I believe line return factory; would never be executed. Look at the code carefully. return statement has followed by another return statement. I would mark that statement as unreachable code.

Mustafa Dwaikat · Accepted Answer · 2016-03-22 12:43:38Z

1

You missed a }

Try this:

(function() {
    angular.module('skindustries').factory('employeeFactory', employeeFactory);
    employeeFactory.$inject = ['$http'];
    function employeeFactory($http) {
        var factory = {};
        var vm = this;
        factory.login = function(email, password) {
            return $http({
                'method': 'POST',
                'url': 'http://domain.dev/api/v1/login',
                'data': $.param({
                'email': email,
                'password': password
                }),
                'headers': {
                'Content-Type': 'application/x-www-form-urlencoded'
                }
            });
        }   
        return factory;
    }
})();

answered Mar 22, 2016 at 12:43

Mustafa Dwaikat

3,70210 gold badges29 silver badges41 bronze badges

Comments

Simple-Solution · Accepted Answer · 2016-03-22 13:35:45Z

0

I would replace self invoking function with this to make it more readable.

 (function() {
    angular.module('skindustries').factory('employeeFactory', ['$http', function ($http) {

      function login(email, password) {
        return $http({
            'method': 'POST',
            'url': 'http://domain.dev/api/v1/login',
            'data': $.param({
            'email': email,
            'password': password
          }),
         'headers': {
           'Content-Type': 'application/x-www-form-urlencoded'
         }
       });
     }


    // expose public api
    return {
      login: login
    };
  }])});

Here is a very good guide on Angular style guide by John Papa

edited Mar 22, 2016 at 13:35

answered Mar 22, 2016 at 13:29

Simple-Solution

4,30912 gold badges50 silver badges66 bronze badges

Comments

Jenish Rabadiya · Accepted Answer · 2016-03-23 03:59:21Z

0

You were having missing } just before return factory

(function() {
  angular.module('skindustries')
    .factory('employeeFactory', employeeFactory);

  employeeFactory.$inject = ['$http'];

  function employeeFactory($http) {
    var factory = {};
    var vm = this;

    factory.login = function(email, password) {
      return $http({
        'method': 'POST',
        'url': 'http://domain.dev/api/v1/login',
        'data': $.param({
          'email': email,
          'password': password
        }),
        'headers': {
          'Content-Type': 'application/x-www-form-urlencoded'
        }
      });
    }
    return factory;
  }
})();

edited Mar 23, 2016 at 3:59

answered Mar 22, 2016 at 12:28

Jenish Rabadiya

6,7766 gold badges35 silver badges62 bronze badges

2 Comments

Quentin Over a year ago

That will error. JS Hint reports: Expected an identifier and instead saw ')'.

Jenish Rabadiya Over a year ago

@Quentin Yup I fixed it.

Collectives™ on Stack Overflow

Angular Js syntax error

4 Answers 4

4 Comments

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related