jquery use variable in string for appendTo

Question

How can I append this URL variable to the list?

I am fiddling around with this: http://jsfiddle.net/Y2ER7/4/

JS:

$(function() {
    var pic = "http://jqueryui.com/demos/droppable/images/high_tatras3_min.jpg";

    // doesn't work
    $("<li><img /></li>").attr("src", pic).appendTo("#album ul");
    $("<li><img src='pic' /></li>").appendTo("#album ul");

    // hardcoded works
    $("<li><img src='http://jqueryui.com/demos/droppable/images/high_tatras3_min.jpg' /></li>").appendTo("#album ul");
});

HTML:

<div id="album">
    <ul>
        <li>red</li>
        <li>green</li>
        <li>blue</li>
    </ul>
</div>

Nick Craver · Accepted Answer · 2010-09-28 17:32:27Z

9

You want to set the src on the <img> so do that then .wrap() it in a <li></li>, like this:

$("<img />").attr("src", pic).wrap("<li />").parent().appendTo("#album ul");

You can test it out here, make sure to use .parent() to get the <li> you wrapped it in.

edited Sep 28, 2010 at 17:32

answered Sep 28, 2010 at 17:22

Nick Craver

631k138 gold badges1.3k silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

TunaFFish Over a year ago

That's great, thanks Nick. Any idea why I loose CSS formatting on my thumbs here: jsfiddle.net/Y2ER7/4

Nick Craver Over a year ago

@FFish - My fault, you need a .parent() in there to get the <li>, .wrap() returns the <img> otherwise, here's your fiddle updated: jsfiddle.net/Y2ER7/5

TunaFFish Over a year ago

Nick = SuperHero. I found a sollution yself though. just addClass with the style for the thumbs. Cheers.

Nick Craver Over a year ago

@FFish - Make sure to use .parent()!, without it you're appending a <img> to a <ul> which is invalid, it needs to be in a <li>.

user113716 · Accepted Answer · 2010-09-28 18:22:47Z

0

You could do something like this: http://jsfiddle.net/Y2ER7/6/

$("<li />", {html:"<img src='" + pic + "' />"}).appendTo("#album ul");

Creates a new <li> element, with its HTML content set as the <img> with pic concatenated in for the src attribute.

EDIT: As described in the comments from @Nick Craver below, if you're unsure of the source of your pic variable, you should not concatenate the src attribute as in this answer.

If you're using a string as in your question, there shouldn't be an issue.

edited Sep 28, 2010 at 18:22

answered Sep 28, 2010 at 17:24

user113716

323k64 gold badges454 silver badges441 bronze badges

7 Comments

Nick Craver Over a year ago

....why would you create one element with DOM methods, then another as a string inside it?

user113716 Over a year ago

@Nick - Lack of experience? :o) I figured there must be some reason why jQuery made the html: option available, but perhaps it is better to not use it?

Nick Craver Over a year ago

@patrick - Just be aware of the dangers, e.g. pic having a quote in it, XSS attach, etc, better to create one way or another, and DOM is always the safer route :)

user113716 Over a year ago

@Nick - Wouldn't the XSS issue be resolved since jQuery is (presumably) calling .html() to set the HTML content?

Nick Craver Over a year ago

@patrick - Nope, that's exactly the issue, blindly doing .innerHTML :) .text(), etc encodes, as will an attribute, it'll take care of many attacks.

|

Collectives™ on Stack Overflow

jquery use variable in string for appendTo

2 Answers 2

4 Comments

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related