Efficient string concatenatation for list of object arrays

Question

so I am building an html table using a list of object arrays, but its going very unacceptably slow. any way to optimize it?

public String generateHtmlTable(List<Object[]> resultSet) {
    totalRows = resultSet.size();

    StringBuilder sb = new StringBuilder();
    sb.append("<table width=\"900px\">");
    sb.append("<tr>");
    sb.append("<th width=\"10%\" align=\"left\"><b>col1</b></th>");
    sb.append("<th width=\"25%\" align=\"left\"><b>col2</b></th>");
    sb.append("<th width=\"20%\" align=\"left\"><b>col3</b></th>");
    sb.append("<th width=\"15%\" align=\"left\"><b>col4</b></th>");
    sb.append("<th width=\"10%\" align=\"left\"><b>col5</b></th>");
    sb.append("<th width=\"10%\" align=\"left\"><b>col6</b></th>");
    sb.append("<th width=\"10%\" align=\"left\"><b>col7</b></th>");
    sb.append("<th width=\"5%\" align=\"left\"><b>col8</b></th>");
    sb.append("<th width=\"5%\" align=\"left\"><b>col9</b></th>");
    sb.append("</tr>");
    for (Object[] row : resultSet) {
        sb.append("<tr>");
        for (Object cell : row) {
            sb.append("<td>");
            sb.append(((cell != null) ? cell.toString() : ""));
            sb.append("</td>");

        }
        sb.append("</tr>");
        rowsProcessed += 1;
    }
    sb.append("</table>");
    return sb.toString();
}

This code doesn't seem to be slow, unless you have thousands of cells/rows in your resultSet. Run your code with the profiler to see what really takes the most of processing time. — Jaroslaw Pawlak
– Jaroslaw Pawlak, Commented Mar 28, 2017 at 9:22
Of course, you could always sacrifice readability and concatenate your strings, reducing the calls to append(). Something like sb.append("<th>...</th>" + "<th> ... </th>" + "<th> ... </th>"); Is that going to help? You would have to try, I guess. Even better would be to omit the + operator as well, if possible. — domsson
– domsson, Commented Mar 28, 2017 at 9:34
Follow-up comment: according to stackoverflow.com/questions/5234147/… it will probably be equally slow/fast when using +. But if your code allows, you could try to omit that entirely and just append all cells in one call. That might help. — domsson
– domsson, Commented Mar 28, 2017 at 9:39
what you can also try is constructing the StringBuilder with a given capacity, so it doesn't need to copy the internal data more often then it need to. — xander
– xander, Commented Mar 28, 2017 at 9:42

Jilles van Gurp · Accepted Answer · 2017-03-28 09:41:29Z

2

You are building the result html in memory before (presumably) streaming it out in your response from some web server. You can avoid buffering like this by writing straight to the response output stream. This has two advantages: 1) you are not creating a copy of your response in memory before returning it. 2) you are returning bytes before you have scrolled through all the results from your database. So both cut down on response time.

Most serialization frameworks on top of e.g. jax.rs would do this for you or you can plug in your own custom serialization. Alternatively if you are using some kind of servlet app, you can just get a writer straight from the response object.

answered Mar 28, 2017 at 9:41

Jilles van Gurp

8,4225 gold badges42 silver badges48 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Efficient string concatenatation for list of object arrays

1 Answer 1

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related