remove the space in keys in a nested object using javascript

Question

I want to replace the whitespace of keys in a nested object. I have an object as follows:

     var data = 
 { 'General Information':
             { 'Referral No': '123123',
               Marketer: '',
               Casemanager: 'Alexis Clark',
               'CM Username': '',
               VOC: '',
               'Foreign Voluntary': '',
            },
     'Account Name': 'CTS Health',
    }

What i did is:

 for (var k in data) {
    if (k.replace(/\s/g, '') !== k) {
        data[k.replace(/\s/g, '')] = data[k];
        if (data[k] !== null && typeof data[k] === 'object') {
            for (var x in data[k]) {
                if (x.replace(/\s/g, '') !== x) {
                    data[k][x.replace(/\s/g, '')] = data[k][x];
                    delete data[k][x];
                }
            }
        }
        delete data[k];
    }
}

I get this:

{ GeneralInformation:
         { 'Referral No': '123123',
           Marketer: '',
           Casemanager: 'Alexis Clark',
           'CM Username': '',
           VOC: '',
           'Foreign Voluntary': '',
        },
    AccountName: 'CTS Health',
  }

What i want is:

{ GeneralInformation:
         { ReferralNo: '123123',
           Marketer: '',
           Casemanager: 'Alexis Clark',
           CMUsername: '',
           VOC: '',
           ForeignVoluntary: '',
        },
    AccountName: 'CTS Health',
  }

What am i doing wrong here??

Wow, that is some jacked up code. Nesting like that is very bad for readability. Avoid using delete — Aluan Haddad
– Aluan Haddad, Commented Apr 21, 2017 at 8:06
@dan, it doesn't even remove the whitespace of the very first key. — Sunil Lama
– Sunil Lama, Commented Apr 21, 2017 at 8:09
@AluanHaddad, Hmmm i really can't get it to work somehow. I know the solution must be really simple. But i am stucked :/ — Sunil Lama
– Sunil Lama, Commented Apr 21, 2017 at 8:10

Nina Scholz · Accepted Answer · 2017-04-21 08:14:29Z

5

You could use an iterative and recursive approach for nested objects.

function replaceKeys(object) {
    Object.keys(object).forEach(function (key) {
        var newKey = key.replace(/\s+/g, '');
        if (object[key] && typeof object[key] === 'object') {
            replaceKeys(object[key]);
        }
        if (key !== newKey) {
            object[newKey] = object[key];
            delete object[key];
        }
    });
}


var data = { 'General Information': { 'Referral No': '123123', Marketer: '', Casemanager: 'Alexis Clark', 'CM Username': '', VOC: '', 'Foreign Voluntary': '', }, 'Account Name': 'CTS Health' };

replaceKeys(data);
console.log(data);

.as-console-wrapper { max-height: 100% !important; top: 0; }

edited Apr 21, 2017 at 8:14

answered Apr 21, 2017 at 8:13

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Aluan Haddad Over a year ago

Nice, beat me to it

Sunil Lama Over a year ago

Nina, got it. Thanks for your answer.

Ratan Kumar · Accepted Answer · 2017-04-21 08:37:51Z

0

Try recursive approach.

var replaceSpace = function (obj) {
  Object.keys(obj).forEach(function(key){
    var newKey = key.split(' ').join('');
    if(object[key] && typeof obj[key] === "object"){
      obj[newKey] = replaceSpace(obj[key])
    }else{
      obj[newKey] = obj[key]
    }

    if(key != newKey)
      delete obj[key]
  })
  return obj
}

edited Apr 21, 2017 at 8:37

answered Apr 21, 2017 at 8:30

Ratan Kumar

1,6503 gold badges26 silver badges52 bronze badges

4 Comments

Aluan Haddad Over a year ago

This will fail if obj[key] === null

Ratan Kumar Over a year ago

a= {};a[null] = 12;typeof a[null]; gives "number" when does it fails ??

Aluan Haddad Over a year ago

typeof null === "object" note the other answers handle this

Aluan Haddad Over a year ago

Right on. JavaScript has lots of pitfalls like that. I never use null in my own code, only undefined. I don't have to worry about this hazard and who needs two nulls. Interestingly, typeof null === "object" was a bug in BE's initial JavaScript engine in 1995. Language got standardized before he could fix it.... go figure

Aluan Haddad · Accepted Answer · 2017-04-21 08:51:02Z

0

We can create a new object instead of mutating the existing one. This both makes it easier to test and also reduces potential for bugs cropping up due to sharing.

function withNormalizedKeys(o) {
  return Object.entries(o)
    .map(([key, value]) => [key.replace(/\s+/g, ''), value])
    .reduce((result, [normalizedKey, value]) => {
      result[normalizedKey] =
      value && typeof value === 'object'
      ? withNormalizedKeys(value)
      : value;
    return result;
  }, {});
}

const data = {
  'General Information': {
    'Referral No': '123123',
    Marketer: '',
    Casemanager: 'Alexis Clark',
    'CM Username': '',
    VOC: '',
    'Foreign Voluntary': ''
  },
  'Account Name': 'CTS Health'
};
const normalized = withNormalizedKeys(data);
console.log(normalized);

edited Apr 21, 2017 at 8:51

answered Apr 21, 2017 at 8:28

Aluan Haddad

32.1k10 gold badges83 silver badges95 bronze badges

5 Comments

Aluan Haddad Over a year ago

It is also good practice for newcomers to learn to use block scoped variables. Also, how is immutable by default not simple?

Aluan Haddad Over a year ago

@BekimBacaj I bet you write for (var i = 0....) { and if you do, it is proof that you are wrong. var, let and const are very different things. And the latter are preferable to the former.

Matt Over a year ago

-1: because you still have the double quotes surrounding the field names - which is what Sunil said he does not want. Also, why is it easier to test if you create a new object (versus updating an existing one)?

Aluan Haddad Over a year ago

@Matt excuse me, but where are double quotes mentioned in the OP? This produces the same output as the accepted answer.

Matt Over a year ago

@AluanHaddad - run your code snippet and check the log output.

MD SHAYON · Accepted Answer · 2021-08-17 11:05:51Z

0

This works great for me

const replaceKeys = (object) => {
    Object.keys(object).forEach(function (key) {
        // const twoLower = key.toLowerCase();
        const removeSpace = key.replace(/\s+/g, '');
        const newKey = removeSpace.toString().toLowerCase();
        if (object[key] && typeof object[key] === 'object') {
            replaceKeys(object[key]);
        }
        if (key !== newKey) {
            object[newKey] = object[key];
            delete object[key];
        }
    });
    return object;

answered Aug 17, 2021 at 11:05

MD SHAYON

8,11156 silver badges43 bronze badges

Collectives™ on Stack Overflow

remove the space in keys in a nested object using javascript

4 Answers 4

2 Comments

4 Comments

5 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

4 Comments

5 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related