cannot apply String values in a Text View array

Question

in if(saveInstanceState != null) I am trying to save the changes of the text in Text Views that happened by whoWon() method to save it in while user rotate the phone and get it back as it was before rotation but it shows me an error that says getText() in TextView cannot be applied to (java.lang.string) , I tried to add .toString() but it didn't work.

public class Multiplayer extends AppCompatActivity {
    private TextView mTicTacTextViews [] = new TextView[9];
    private Button mButtonX;
    private Button mButtonO;
    private Button mResult;
    private int mcheckAllButtonsClicked =0;
    private String TEXT_VIEW_VALUES_KEY = "VALUES OF TEXT VIEW'S";
    private String mTextviewValues [] = new String[9];
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        if(savedInstanceState != null)
        {
            String values[]=savedInstanceState.getStringArray(TEXT_VIEW_VALUES_KEY);
            for (int i=0;i<values.length;i++ ) {
                mTextviewValues[i]=values[i];
                mTicTacTextViews[i].getText(mTextviewValues[i]);
            }

        }

        setContentView(R.layout.activity_tic_tac);

        mTicTacTextViews[0] = (TextView) findViewById(R.id.tic_tac_one);
        mTicTacTextViews[0].setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {

               ifPressed_XButton(mTicTacTextViews[0]);
                ifPressed_OButton(mTicTacTextViews[0]);
                mcheckAllButtonsClicked+=1;
            }
        });

        mTicTacTextViews[1] = (TextView) findViewById(R.id.tic_tac_two);
        mTicTacTextViews[1].setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                ifPressed_XButton(mTicTacTextViews[1]);
                ifPressed_OButton(mTicTacTextViews[1]);
                mcheckAllButtonsClicked+=1;
            }
        });

        mTicTacTextViews[2] = (TextView) findViewById(R.id.tic_tac_three);
        mTicTacTextViews[2].setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                ifPressed_XButton(mTicTacTextViews[2]);
                ifPressed_OButton(mTicTacTextViews[2]);
                mcheckAllButtonsClicked+=1;
            }
        });

        mTicTacTextViews[3] = (TextView) findViewById(R.id.tic_tac_four);
        mTicTacTextViews[3].setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                ifPressed_XButton(mTicTacTextViews[3]);
                ifPressed_OButton(mTicTacTextViews[3]);
                mcheckAllButtonsClicked+=1;
            }
        });
        mTicTacTextViews[4] = (TextView) findViewById(R.id.tic_tac_five);
        mTicTacTextViews[4].setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                ifPressed_XButton(mTicTacTextViews[4]);
                ifPressed_OButton(mTicTacTextViews[4]);
                mcheckAllButtonsClicked+=1;
            }
        });

        mTicTacTextViews[5] = (TextView) findViewById(R.id.tic_tac_six);
        mTicTacTextViews[5].setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                ifPressed_XButton(mTicTacTextViews[5]);
                ifPressed_OButton(mTicTacTextViews[5]);
                mcheckAllButtonsClicked+=1;
            }
        });

        mTicTacTextViews[6] = (TextView) findViewById(R.id.tic_tac_seven);
        mTicTacTextViews[6].setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                ifPressed_XButton(mTicTacTextViews[6]);
                ifPressed_OButton(mTicTacTextViews[6]);
                mcheckAllButtonsClicked+=1;
            }
        });

        mTicTacTextViews[7] = (TextView) findViewById(R.id.tic_tac_eight);
        mTicTacTextViews[7].setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                ifPressed_XButton(mTicTacTextViews[7]);
                ifPressed_OButton(mTicTacTextViews[7]);
                mcheckAllButtonsClicked+=1;
            }
        });

        mTicTacTextViews[8] = (TextView) findViewById(R.id.tic_tac_nine);
        mTicTacTextViews[8].setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                ifPressed_XButton(mTicTacTextViews[8]);
                ifPressed_OButton(mTicTacTextViews[8]);
                mcheckAllButtonsClicked+=1;

            }
        });



        mButtonX = (Button) findViewById(R.id.x_button);
        mButtonX.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                mUserPressed_XButton =true;
            }
        });

        mButtonO = (Button) findViewById(R.id.o_button);
        mButtonO.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                mUserPressed_OButton =true;

            }
        });

        mTextviewValues [0]=mTicTacTextViews[0].getText().toString();
        mTextviewValues [1]=mTicTacTextViews[1].getText().toString();
        mTextviewValues [2]=mTicTacTextViews[2].getText().toString();
        mTextviewValues [3]=mTicTacTextViews[3].getText().toString();
        mTextviewValues [4]=mTicTacTextViews[4].getText().toString();
        mTextviewValues [5]=mTicTacTextViews[5].getText().toString();
        mTextviewValues [6]=mTicTacTextViews[6].getText().toString();
        mTextviewValues [7]=mTicTacTextViews[7].getText().toString();
        mTextviewValues [8]=mTicTacTextViews[8].getText().toString();

        mResult = (Button) findViewById(R.id.result_button);
        mResult.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View view) {
                whoWon();
            }
        });
    }



    private void whoWon ()
    {
        mTextviewValues [0]=mTicTacTextViews[0].getText().toString();
        mTextviewValues [1]=mTicTacTextViews[1].getText().toString();
        mTextviewValues [2]=mTicTacTextViews[2].getText().toString();
        mTextviewValues [3]=mTicTacTextViews[3].getText().toString();
        mTextviewValues [4]=mTicTacTextViews[4].getText().toString();
        mTextviewValues [5]=mTicTacTextViews[5].getText().toString();
        mTextviewValues [6]=mTicTacTextViews[6].getText().toString();
        mTextviewValues [7]=mTicTacTextViews[7].getText().toString();
        mTextviewValues [8]=mTicTacTextViews[8].getText().toString();

        if(mTextviewValues[0].equals(mTextviewValues[1]) & mTextviewValues[1].equals(mTextviewValues[2]))
        {
            Toast.makeText(this,"Someone won",Toast.LENGTH_SHORT).show();
        }
        else if (mTextviewValues[1].equals(mTextviewValues[4]) & mTextviewValues[4].equals(mTextviewValues[8]))
        {
            Toast.makeText(this,"Someone won",Toast.LENGTH_SHORT).show();
        }
        else if (mTextviewValues[0].equals(mTextviewValues[3]) & mTextviewValues[3].equals(mTextviewValues[6]))
        {
            Toast.makeText(this,"Someone won",Toast.LENGTH_SHORT).show();
        }
        else if (mTextviewValues[1].equals(mTextviewValues[4]) & mTextviewValues[4].equals(mTextviewValues[7]))
        {
            Toast.makeText(this,"Someone won",Toast.LENGTH_SHORT).show();
        }
        else if (mTextviewValues[2].equals(mTextviewValues[5]) & mTextviewValues[5].equals(mTextviewValues[8]))
        {
            Toast.makeText(this,"Someone won",Toast.LENGTH_SHORT).show();
        }
        else if (mTextviewValues[2].equals(mTextviewValues[4]) & mTextviewValues[4].equals(mTextviewValues[6]))
        {
            Toast.makeText(this,"Someone won",Toast.LENGTH_SHORT).show();
        }

        else if (mTextviewValues[2].equals(mTextviewValues[4]) & mTextviewValues[4].equals(mTextviewValues[6]))
        {
            Toast.makeText(this,"Someone won",Toast.LENGTH_SHORT).show();
        }
        else if (mTextviewValues[6].equals(mTextviewValues[7]) & mTextviewValues[7].equals(mTextviewValues[8]))
        {
            Toast.makeText(this,"Someone won",Toast.LENGTH_SHORT).show();
        }
        else Log.i("error" , "whowon didn't work");

    }
    @Override
    protected void  onSaveInstanceState(Bundle bundle)
    {
        super.onSaveInstanceState(bundle);
        bundle.putStringArray(TEXT_VIEW_VALUES_KEY,mTextviewValues);

    }
}

Can you take out the superfluous code? How to Ask a question recommends using a minimal reproducible example. — Paul Hicks
– Paul Hicks, Commented Sep 4, 2017 at 0:04

Paul Hicks · Accepted Answer · 2017-09-04 00:03:58Z

3

getText() doesn't take a parameter. mTicTacTextViews[i].getText() returns the text in the view. Are you trying to set the text in the view? If so, you want setText(CharSequence), not CharSequence getText().

answered Sep 4, 2017 at 0:03

Paul Hicks

14.1k5 gold badges58 silver badges86 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

LCTS Over a year ago

app crashing, with error "Attempt to invoke virtual method 'void android.widget.TextView.setText(java.lang.CharSequence)' on a null object reference"

Paul Hicks Over a year ago

That implies that your TextView variable is null. Which makes sense, since you don't populate it until further down the (very, very long) method.

LCTS Over a year ago

No, I do give mTextViewValues[] it text values in onCreate() not only in whoWon()

Paul Hicks Over a year ago

Yes, but the problem is that mTicTacTextViews[i] is null. Move your if(savedInstanceState != null) down near setOnClickListener and you should be better off.

Paul Hicks Over a year ago

Also, you'll find it a lot easer going if you break your onCreate down into multiple methods. Like createTextView(id), populateTextView(id), createXButton, createOButton and setupListener. Then you'll find it easier to spot where you're populating views before you create them.

Collectives™ on Stack Overflow

cannot apply String values in a Text View array

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related