Refactor javascript if statement

Question

I have a unusual nested if statement where a third condition is needed to execute some code, but this condition is independent of my else clause. Thus, I've nested this condition inside the outer 2 conditions. The below works as it should, but I'm not positive this is the best way to handle a case like this. Should I use another method or refactor this in a way I'm not thinking of?

if ($('#preferred-contact').prop('selectedIndex') == index && !$(selector).val())
{
    if (!$(label).parent().hasClass('has-error')) {
        $(selector).after("<span class='help-block form-error'>Required Field</span>");
        $(label).parent().addClass('has-error');
    }
}
else {
    $(selector + ' + .help-block').remove();
    $(label).parent().removeClass('has-error');
}

This is not a question for Stack Overflow. It's best handled at codereview.stackexchange.com — Scott Marcus
– Scott Marcus, Commented Nov 15, 2017 at 15:43
gee thanks for all the help @ScottMarcus you're one of the good ones — noclist
– noclist, Commented Dec 4, 2017 at 15:56

sergeyski.com · Accepted Answer · 2020-11-20 12:21:36Z

2

Your First if statement has a second if statement but, not other code.

Why just create a single condition for that ?

let myCondition = index === $('#preferred-contact').prop('selectedIndex') && !$(selector).val();

if (myCondition && !$(label).parent().hasClass('has-error'))
{
    $(selector).after("<span class='help-block form-error'>Required Field</span>");
    $(label).parent().addClass('has-error');
}
else if (!myCondition)
{
    $(selector + ' + .help-block').remove();
    $(label).parent().removeClass('has-error');
}

With that you reduce the cyclomatic complexity and improve your code. In every language you should coding with the least level of nesting possible.

edited Nov 20, 2020 at 12:21

sergeyski.com

6067 silver badges15 bronze badges

answered Nov 15, 2017 at 15:55

Doc Roms

3,3081 gold badge22 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

madox2 Over a year ago

Actually this does not do the same as the original code. Imagine use case where first condition is fulfilled and inner condition not

Doc Roms Over a year ago

Gg ^_^ you're right! My previous code not respected the original post. Thanks you :) I edit my post for respect the sub-condition.

Scott Marcus Over a year ago

Please don't provide answers to questions that don't belong on Stack Overflow in the first place. It just encourages more of the same, in terms of questions and dilutes the quality of the questions.

madox2 · Accepted Answer · 2017-11-15 15:48:24Z

-1

The way you are using conditionals if fine enaugh. However if you insist on getting rid of inner condition, you can rewrite it from backwards and use else if:

if ($('#preferred-contact').prop('selectedIndex') != index || $(selector).val())
{
    $(selector + ' + .help-block').remove();
    $(label).parent().removeClass('has-error');
}
else if (!$(label).parent().hasClass('has-error')) {
    $(selector).after("<span class='help-block form-error'>Required Field</span>");
    $(label).parent().addClass('has-error');
}

answered Nov 15, 2017 at 15:48

madox2

52.3k21 gold badges106 silver badges101 bronze badges

6 Comments

madox2 Over a year ago

Why downwote? Am I missing something?

Scott Marcus Over a year ago

Please don't provide answers to questions that don't belong on Stack Overflow in the first place. It just encourages more of the same, in terms of questions and dilutes the quality of the questions.

madox2 Over a year ago

@ScottMarcus if somebody asks for help and anybody can answer, then it was the right place to ask. That is what stackoverflow is about.

Scott Marcus Over a year ago

Well, no, not really. Stack Overflow has guidelines for the types of questions that should be asked and that's why we have the "Close" option available to members with enough rep. This question is "off-topic" and should not be posted to SO.

madox2 Over a year ago

@ScottMarcus sure there are guidelines. However imho SO is more about helping people than categorizing content.

|

Collectives™ on Stack Overflow

Refactor javascript if statement

2 Answers 2

3 Comments

6 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

6 Comments

Your Answer

Sign up or log in

Post as a guest

Related