Trigger toggle if URL is in array

Question

I have a menu with multiple jQuery toggles in it and I wanted to have jQuery toggle open one if the page URL matched. I guessed that I would need an array to keep the code short, but I know I'm doing something wrong.

$(function() {
    var pathname = window.location.pathname;
var myWhoweare = new Array("history.asp","corporate_profile.asp");

if(jQuery.inArray(pathname, myWhoweare) !== -1) {
      $('div.accordian_whoweare> div').show();
    }
});

I'm pretty sure that my error is in how the array is created (there are two URLs in it for this test, there will be more later) and detected.

Any help would be appreciated.

Felix Kling · Accepted Answer · 2011-03-20 23:06:13Z

3

location.pathname has a forward slash as first character. Add it to the URLs in your array (and use array literal notation):

$(function() {
    var pathname = window.location.pathname;
    var myWhoweare = ["/history.asp","/corporate_profile.asp"];

    if($.inArray(pathname, myWhoweare) !== -1) {
        $('div.accordian_whoweare> div').show();
    }
});

If you are going to add more URLs, more efficient would be to use a map (or hash table, however you want to call it), realised by a JavaScript object:

$(function() {
    var pathname = window.location.pathname;
    var myWhoweare = {
        "/history.asp": true,
        "/corporate_profile.asp": true
    };

    if(myWhoweare[pathname]) {
        $('div.accordian_whoweare> div').show();
    }
});

Testing whether the URL is contained in the map will be O(1) (whereas the runtime for finding a value in the array will obviously be higher).

edited Mar 20, 2011 at 23:06

answered Mar 20, 2011 at 23:00

Felix Kling

820k181 gold badges1.1k silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

stephmoreland Over a year ago

Thanks very much, that worked! I knew I was missing something.

alex Over a year ago

You could also ditch the leading / and do substring(1) on the pathname. +1 because I think it is a good answer :)

Collectives™ on Stack Overflow

Trigger toggle if URL is in array

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related