Replacing existing array with array from a Function

Question

Okay, I'm adding a value to each value in the array and I want to replace the sum of the two values for each array value with the existing array. If this function was initated again, it would add on top of the "new" array.

var howMuch = 1;

var numbers = [
    700,
    800,
    900,
    1000,
    1100,
    1200,
    1300,
    1400,
    1500,
    1600,
    1700,
    1800,
    1900
  ];

function change (string) {
  if(string === 'success'){
     for(var i = 0; i < numbers.length){
        return numbers[i] + howMuch;
      }
   }
}

change('success');


// I'm expecting the global numbers array to be 

    701,
    801,
    901,
    1001,
    1101,
    1201,
    1301,
    1401,
    1501,
    1601,
    1701,
    1801,
    1901
  ];

and if ran again: 

702,
802,
902,
1002,
etc........

THANK YOU IN ADVANCE!!!!

the code is mostly fine, although as you are operating on a global variable you don't need to return from the function, just modify the value. Also you're missing the increment i++ from the for loop — chrismclarke
– chrismclarke, Commented Aug 22, 2019 at 13:44

chrismclarke · Accepted Answer · 2019-08-22 13:55:52Z

1

function change (status) {
  if(status === 'success'){
     for(var i = 0; i < numbers.length; i++){
        numbers[i] += howMuch;
      }
   }
}

edited Aug 22, 2019 at 13:55

answered Aug 22, 2019 at 13:43

chrismclarke

2,11512 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Apolo Over a year ago

This is the best answer, but it would be nice not to use "string" as a parameter name since it is a restricted keyword in javascript

some Over a year ago

@Apolo Actually, "string" is not a reserved keyword, but it is still a bad name. It is better to give the variable a name that describes what it does instead of what type it is.

jeph · Accepted Answer · 2019-08-22 13:57:44Z

0

i would suggest map function together with an arrow callback function.

    function change (word) {
       if(word === 'success'){
          numbers=numbers.map(item=>item+howMuch)
       }
     }

edited Aug 22, 2019 at 13:57

answered Aug 22, 2019 at 13:49

jeph

825 bronze badges

Collectives™ on Stack Overflow

Replacing existing array with array from a Function

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related