Fix string for JavaScript in C#

Question

I have a function that fixed non-printable characters in C# for JavaScript. But it works very slow! How to increase speed of this function?

private static string JsStringFixNonPrintable(string Source)
    {
        string Result = "";
        for (int Position = 0; Position < Source.Length; ++Position)
        {
            int i = Position;
            var CharCat = char.GetUnicodeCategory(Source, i);
            if (Char.IsWhiteSpace(Source[i]) ||
                CharCat == System.Globalization.UnicodeCategory.LineSeparator ||
                CharCat == System.Globalization.UnicodeCategory.SpaceSeparator) { Result += " "; continue; }
            if (Char.IsControl(Source[i]) && Source[i] != 10 && Source[i] != 13) continue;
            Result += Source[i];
        }
        return Result;
    }

I'd check out stackoverflow.com/questions/1120198/… for a regexp method as an alternative. — James Khoury
– James Khoury, Commented Jun 17, 2011 at 3:59

Miguel Angelo · Accepted Answer · 2011-06-17 03:51:19Z

I have recoded your snippet of code using StringBuilder class, with predefined buffer size... that is much faster than your sample.

    private static string JsStringFixNonPrintable(string Source)
    {
        StringBuilder builder = new StringBuilder(Source.Length); // predefine size to be the same as input
        for (int it = 0; it < Source.Length; ++it)
        {
            var ch = Source[it];
            var CharCat = char.GetUnicodeCategory(Source, it);
            if (Char.IsWhiteSpace(ch) ||
                CharCat == System.Globalization.UnicodeCategory.LineSeparator ||
                CharCat == System.Globalization.UnicodeCategory.SpaceSeparator) { builder.Append(' '); continue; }
            if (Char.IsControl(ch) && ch != 10 && ch != 13) continue;
            builder.Append(ch);
        }
        return builder.ToString();
    }

bobbymcr · Accepted Answer · 2011-06-17 03:45:05Z

1

Instead of concatenating to the string, try using System.Text.StringBuilder which internally maintains a character buffer and does not create a new object every time you append.

Example:

StringBuilder sb = new StringBuilder();
sb.Append('a');
sb.Append('b');
sb.Append('c');
string result = sb.ToString();
Console.WriteLine(result); // prints 'abc'

answered Jun 17, 2011 at 3:45

bobbymcr

24.3k3 gold badges59 silver badges68 bronze badges

Comments

Adithya Surampudi · Accepted Answer · 2011-06-17 03:48:14Z

0

Use Stringbuilder

http://msdn.microsoft.com/en-us/library/system.text.stringbuilder.aspx

and replace characters in-place, that should speed up things

answered Jun 17, 2011 at 3:48

Adithya Surampudi

4,4441 gold badge20 silver badges17 bronze badges

Collectives™ on Stack Overflow

Fix string for JavaScript in C#

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related