How to properly pass custom variables to Demand in TYPO3 12 News system extension?

It’s working.

Why this happens:

TYPO3 Extbase uses plugin namespaces to separate parameters from different plugins.

Namespaces prevent parameter conflicts between different plugins on the same page.

• The standard news plugin uses tx_news_pi1.

• Your extended plugin could use tx_bbextendnews_pi1.

• $this->request->getArgument() only looks in its own plugin namespace.

• GeneralUtility::_GP() can query all namespaces.

A getNewsAuthorFromRequest function was created that searches for the value across all namespaces. In the listAuthorAction function, we retrieve this value into the demand object. Additionally, the controller was corrected according to TYPO3 v12 requirements.

1. ResponseInterface:

2. public function __construct()

<?php
namespace BB\BbExtendNews\Controller;

/***
 *
 * This file is part of the "Extend News" Extension for TYPO3 CMS.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 *  (c) 2018 Kay Röseler <[email protected]>, BippesBrandão GmbH
 *
 ***/

use GeorgRinger\News\Domain\Repository\CategoryRepository;
use GeorgRinger\News\Domain\Repository\TagRepository;
use GeorgRinger\News\Event\NewsListActionEvent;
use GeorgRinger\News\Utility\Cache;
use Psr\Http\Message\ResponseInterface;
use TYPO3\CMS\Core\Utility\GeneralUtility;
use GeorgRinger\News\Domain\Repository\NewsRepository;


/**
 * Class NewsController
 * @package BB\BbExtendNews\Controller
 */
class NewsController extends \GeorgRinger\News\Controller\NewsController {

    /**
     * Output a list view of news
     *
     * @param array $overwriteDemand
     *
     * @throws \InvalidArgumentException
     * @throws \TYPO3\CMS\Extbase\Mvc\Exception\NoSuchArgumentException
     * @throws \UnexpectedValueException
     */

    protected NewsRepository $newsRepository;

    protected CategoryRepository $categoryRepository;

    protected TagRepository $tagRepository;

    /** @var array */
    protected $ignoredSettingsForOverride = ['demandclass', 'orderbyallowed', 'selectedList'];

    /**
     * Original settings without any magic done by stdWrap and skipping empty values
     *
     * @var array
     */
    protected $originalSettings = [];

    public function __construct(
        NewsRepository $newsRepository,
        CategoryRepository $categoryRepository,
        TagRepository $tagRepository
    ) {
        $this->newsRepository = $newsRepository;
        $this->categoryRepository = $categoryRepository;
        $this->tagRepository = $tagRepository;
    }


    protected function getNewsAuthorFromRequest(): ?int
    {
        $newsAuthorUid = null;

  
        if (!$newsAuthorUid) {
            $namespacesToCheck = [
                'tx_news_pi1',
                'tx_bbextendnews_pi1',
                'tx_news',
                'tx_bbextendnews'
            ];

            foreach ($namespacesToCheck as $namespace) {
                $params = \TYPO3\CMS\Core\Utility\GeneralUtility::_GP($namespace);
                if (is_array($params) && isset($params['newsAuthor'])) {
                    $newsAuthorUid = (int)$params['newsAuthor'];
                    \TYPO3\CMS\Core\Utility\DebugUtility::debug($newsAuthorUid, 'From Namespace: ' . $namespace);
                    break;
                }
            }
        }

        return $newsAuthorUid ?: null;
    }

    public function listAuthorAction(?array $overwriteDemand = null): ResponseInterface
    {
        $demand = $this->createDemandObjectFromSettings($this->settings);
        $demand->setActionAndClass(__METHOD__, __CLASS__);

        if ($this->settings['disableOverrideDemand'] != 1 && $overwriteDemand !== null) {
            $demand = $this->overwriteDemandObject($demand, $overwriteDemand);
        }

        $newsAuthorUid = $this->getNewsAuthorFromRequest();

       /* Typo3 12  It doesn't work ($this->request->hasArgument('newsAuthor')) {
            $newsAuthor = (int)$this->request->getArgument('newsAuthor');
            $demand->setNewsAuthor($newsAuthor);
        }*/

        if ($newsAuthorUid) {
            $demand->setNewsAuthor($newsAuthorUid);
          //  \TYPO3\CMS\Core\Utility\DebugUtility::debug($newsAuthorUid, 'Setting NewsAuthor UID');
        }

        // test
       // $newsAuthor = 4;
       // $demand->setNewsAuthor($newsAuthor);

        \TYPO3\CMS\Extbase\Utility\DebuggerUtility::var_dump($demand);

        $newsRecords = $this->newsRepository->findDemanded($demand);

       /* foreach ($newsRecords as $newsItem) {
            if ($newsItem->getNewsAuthor()) {
                $authorUid = $newsItem->getNewsAuthor()->_getProperty('uid');
                \TYPO3\CMS\Core\Utility\DebugUtility::debug($authorUid, 'Author UID');
            }
        }*/

        $assignedValues = [
            'news' => $newsRecords,
            'overwriteDemand' => $overwriteDemand,
            'demand' => $demand,
            'categories' => null,
            'tags' => null,
        ];

        if ($demand->getCategories() !== '') {
            $categoriesList = $demand->getCategories();
            if (!is_array($categoriesList)) {
                $categoriesList = GeneralUtility::trimExplode(',', $categoriesList);
            }
            if (!empty($categoriesList)) {
                $assignedValues['categories'] = $this->categoryRepository->findByIdList($categoriesList);
            }
        }

        if ($demand->getTags() !== '') {
            $tagList = $demand->getTags();
            if (!is_array($tagList)) {
                $tagList = GeneralUtility::trimExplode(',', $tagList);
            }
            if (!empty($tagList)) {
                $assignedValues['tags'] = $this->tagRepository->findByIdList($tagList);
            }
        }

        $event = $this->eventDispatcher->dispatch(new NewsListActionEvent($this, $assignedValues, $this->request));
        $this->view->assignMultiple($event->getAssignedValues());

        Cache::addPageCacheTagsByDemandObject($demand);
        return $this->htmlResponse();
    }
}